Category style bullet now enabled on meta


(Sam Saffron) #1

I have temporarily set the category style on meta to bullet which @awesomerobot just added :heart:

I want to make sure we have all the styling right and the only way to ensure that is live with it.

Please reply here if you notice any alignment issues etc.


(Jacob Chapel) #2

I’ve enabled it and am liking it so far.

A few spots where alignment is off

Default

Dropbox - Screenshot 2015-03-09 23.34.19.png

Dropbox - Screenshot 2015-03-09 23.40.35.png

Dropbox - Screenshot 2015-03-09 23.42.45.png

Dropbox - Screenshot 2015-03-09 23.36.01.png

Dropbox - Screenshot 2015-03-10 00.01.22.png

Dropbox - Screenshot 2015-03-09 23.42.11.png


Sams Minimal

Dropbox - Screenshot 2015-03-09 23.33.29.png

Dropbox - Screenshot 2015-03-09 23.34.04.png

Dropbox - Screenshot 2015-03-09 23.35.04.png

Dropbox - Screenshot 2015-03-09 23.35.31.png

Dropbox - Screenshot 2015-03-09 23.38.44.png

Dropbox - Screenshot 2015-03-10 00.01.58.png

No (or minor) Issues

Though like a pixel or two off from vertical center, or maybe that is the text. Hard to say since it’s lowercase.
Dropbox - Screenshot 2015-03-09 23.36.27.png

Dropbox - Screenshot 2015-03-09 23.44.09.png


Dropbox Onebox embeds in details aren't working?
(Sam Saffron) #3

Those look like mostly issues with my theme, you need to test in default style


(Jacob Chapel) #4

I added comparison ones with default, there are still issues with default.


(Sam Saffron) #6

Bug on iPhone is cropped


(Kris) #7

Submitted a PR that should handle some alignment issues; there were some minor 1-2px alignment differences between Firefox and Webkit that should be fixed now.

https://github.com/discourse/discourse/pull/3265


(Sam Saffron) #9

Awesome… one more, this time with tagger


(Sam Saffron) #11

If you feel like bikeshedding about the merits and demerits of the NON DEFAULT bullet style … take it here


(Michael Downey) #12

Looks great with our non-standard header (black background and Open Sans / Roboto font combination). Previously had to do all kinds of positioning hacks.

:+1:


(Sam Saffron) #13

@awesomerobot minor but annoying, bottom of g in bug is cropped on safari/chrome iOS 8


(Sam Saffron) #14

@awesomerobot we are still struggling with alignment here:

  1. howto is 1px too high
  2. import tag is 3px too high

(Kris) #15

Does merging this tagging-plugin PR fix the tag alignment (will have to look at the category alignment)? Should have mentioned that I made an adjustment to the CSS in Discourse and also the plugin.

https://github.com/discourse/discourse-tagging/pull/25


(Jens Maier) #16

Just found some more misalignments in the profile settings:


(Wes Osborn) #17

I’m seeing some issues with text wrapping/overlapping in the hamburger menu in Chrome since switching to bullet style chips:

We have longer category names than most which I’m assuming is why we are seeing this problem.


(Kris) #18

We should truncate that text; easy fix. I’ll add it over the next few days!