Change staff-email adress confirmation message unclear

[Bas (Bas van Leeuwen (OOO until November 5))]

tl;dr: js.user.change_email.success should be slightly altered

Reproduction path:

• go to your staff profile
• change your email address from (original@example.com to changed@example.com), click confirm
• see this confirmation:
  

Expected:

• open inbox of changed@example.com
• confirm new email

Actual:

• open inbox of changed@example.com
• don’t see a new email
  - debug your email settings
  - can’t find a thing
  - throw your hands up in despair
  - wait for a while
• open inbox of original@example.com
• see email that you need to confirm ownership of original@example.com

Suggested fix:
Change js.user.change_email.success to “We’ve sent an email to your original address. Please follow the confirmation instructions.”

[edit] changed to show it only happens for staff-emails

[fefrei (Felix Freiberger)]

This behavior should only happen for staff (but I agree that the copy should be edited for them).

[Bas (Bas van Leeuwen (OOO until November 5))]

Ah, that behaviour makes a lot of sense! Thanks Discourse for watching out for us

Makes the fix less trivial though

[neil (Neil Lalonde)]

It should have its own message for staff. I agree it’s confusing.

[neil (Neil Lalonde)]

I made a change for this. The new message for staff is js.user.change_email.success_staff:

We’ve sent an email to your current address. Please follow the confirmation instructions.