Incorrect message when staff user changes email for non-staff user


(Joshua Rosenfeld) #1

For security purposes when a staff user changes their email address they must verify both the current and new email. For non-staff users they only need to verify the new email.

If a non-staff user changes their email they see the correct message:

We've sent an email to that address. Please follow the confirmation instructions.

However, if a staff user changes a non-staff user’s email they see the (incorrect) staff message:

We've sent an email to your current address. Please follow the confirmation instructions.

As the email was changed for a non-staff user no current address confirmation is required. Discourse correctly sends an email only to the new address, but this message is confusing to staff (who think the user needs to verify the current address).


(Jeff Atwood) #3

Agreed we should fix this, could result in support issues. Hopefully easy perhaps @neil can take a look tomorrow?


(Jay Pfaffman) #5

Ooooh! Yes! I am those staff who were very confused. (sometimes a like isn’t enough).

I thought I was just crazy.


(Neil Lalonde) #6

This was an easy one.


(Joshua Rosenfeld) #7

This topic was automatically closed after 26 hours. New replies are no longer allowed.