Change to the way user mentions are displayed

Not sure if this is related to the recent DDoS attack, but I have noticed that user mentions look different than they used to. Now if I mention @jomaxro it appears to have a grey font color. Before, it would look like this: with black text.

Is this a side effect of the attack, or a feature change I just missed :wink:?

1 лайк

Not related, it was a recent change made.
https://github.com/discourse/discourse/commit/6d6d8842d234ecd1035e91693ee431eb1cb9a400

3 лайка

Ah, thanks. Any particular reason why (that you know of)?

No idea. I’m not a fan of it yet, as I find it harder to find where I am mentioned in a long topic now, but I need to give it more time. The contrast is now horrid for those with eye sight problems.

3 лайка

I tend to agree with you here. Yes, change is hard (for everyone), but I agree that it is tougher to see, and without knowing the reason the change was made it seems like change for the sake of change.

Yes, not everyone has good vision. For me it looks like a grey bar unless I move closer and squint.

For me it isn’t so hard to read bolded

@codinghorror I find the contrast a bit too soft, can we lighten the gray background a bit?

Or just drop the background altogether?

Actually I think the foreground should be dropped to #646464 which would match the username color used in the top of posts.

Current new combo fails WebAIM: Contrast Checker which is particularly painful on sections of text you need to read.

Many people have crappy monitors that do bad with problem contrast and many people have eyes that can not cope with it.

3 лайка

Probably fine, but #222 was too black.

1 лайк

Having trouble understanding the motivations here too. I’m finding the latest revision harder to read.

Maybe worth a closer look at what Slack does? @mentions that I’m not included on look like normal links. Ones that mention @me or @groups i’m in directly are highlighted in yellow.

1 лайк

@mcwumbly Я просто подстроил его под тот же цвет, что и у имени пользователя в заголовке поста. Думаю, это выглядит уместно, возможно, стоит также поэкспериментировать с жирным начертанием, чтобы добиться полного совпадения.

Я считаю, что выделение упоминаний — очень интересная идея. Первый шаг — внедрить соответствующий класс, но это немного сложно, так как нам придётся запускать постобработку markdown для каждого отображаемого поста.

С точки зрения UX интересно, что ссылка Contribute > UX считается «более» важной, чем простое упоминание, которое, по сути, является лишь наблюдением.

2 лайка

I kind of like it in bold 1px smaller.

It ties super cleanly with the way we display username in the topic title, so brain goes … ahh this is a username, right away.

@codinghorror should I make this change?

2 лайка

Sure bold would be consistent with category hash so that’s fine.

1 лайк

No? Just a decoratePost callback with this.$('.mention[href="/users/' + username + '"]').addClass('you-mention');

3 лайка