Changed text for `topic withdrawn by author` doesn't apply

bug
1

Steps to reproduce:

  1. Change the js.topic.deleted_by_author.one and js.topic.deleted_by_author.other to anything the already existing text ((topic withdrawn by author, will be automatically deleted in 24 hours unless flagged)) in Customize > Text,
  2. Add a topic as a regular user.
  3. Delete the topic as a regular user
  4. Expected to see the updated text, but (topic withdrawn by author, will be automatically deleted in 24 hours unless flagged) is displayed.

Issue could be in this code:
https://github.com/discourse/discourse/blob/master/lib/post_destroyer.rb#L181

It seems that js.topic.deleted_by_author.one or js.topic.deleted_by_author.other are not referenced here, but only js.topic.deleted_by_author, which does not exist in locales config.

2 Likes
2

Is this a bug for us to fix @sam?

2 Likes
3

This is occurring because the self-deletion text is translated and stored on the server as a post revision. The translation change will only take effect for newly deleted posts.

6 Likes
4

@riking So this is not a bug? I am not sure, we had this part translated early on and this issue still persists even on new posts.

1 Like