Changed text for `topic withdrawn by author` doesn't apply

zcuric · 6 Maggio 2020, 9:13am

Steps to reproduce:

Change the js.topic.deleted_by_author.one and js.topic.deleted_by_author.other to anything the already existing text ((topic withdrawn by author, will be automatically deleted in 24 hours unless flagged)) in Customize > Text,
Add a topic as a regular user.
Delete the topic as a regular user
Expected to see the updated text, but (topic withdrawn by author, will be automatically deleted in 24 hours unless flagged) is displayed.

Issue could be in this code:

lib/post_destroyer.rb

main


      
            end
          
            # skip also publishing topic stats because they weren't updated yet
            @post.publish_change_to_clients! :recovered, { skip_topic_stats: true }
            TopicTrackingState.publish_recover(@post.topic) if @post.topic && @post.is_first_post?
          end
          
          # When a post is properly deleted. Well, it's still soft deleted, but it will no longer
          # show up in the topic
          # Permanent option allows to hard delete.
          def perform_delete
            # All posts in the topic must be force deleted if the first is force
            # deleted (except @post which is destroyed by current instance).
            if @topic && @post.is_first_post? && permanent?
              @topic.posts.with_deleted.find_each do |post|
                PostDestroyer.new(@user, post, @opts).destroy if post.id != @post.id
              end
            end
          
            Post.transaction do
              permanent? ? @post.destroy! : @post.trash!(@user)

It seems that js.topic.deleted_by_author.one or js.topic.deleted_by_author.other are not referenced here, but only js.topic.deleted_by_author, which does not exist in locales config.

codinghorror · 6 Maggio 2020, 7:26pm

Is this a bug for us to fix @sam?

riking · 6 Maggio 2020, 9:56pm

This is occurring because the self-deletion text is translated and stored on the server as a post revision. The translation change will only take effect for newly deleted posts.

zcuric · 11 Maggio 2020, 7:27pm

@riking So this is not a bug? I am not sure, we had this part translated early on and this issue still persists even on new posts.

Argomento		Risposte	Visualizzazioni
Some of Site Texts doesn't accept changes Support	10	718	Settembre 30, 2020
Deleted posts from different UI languages show 'withdrawn post' in said language Bug	3	1042	Gennaio 28, 2015
Edit reason: "reverted to version" text not translatable UX translation	2	440	Febbraio 11, 2023
Custom text in js.topic.read_more_MF not displaying Bug	2	1108	Aprile 9, 2016
Custom text has disappeared Support	3	365	Gennaio 29, 2021

Changed text for `topic withdrawn by author` doesn't apply

Argomenti correlati