Changes to email templates not saving


#1

I have a report of someone that has been trying to update their email templates but the changes are not saving.

So far it has happened with both the Account Created and the Invite Mailer templates.

When they click “Save Changes” the “Saved!” message is returned but the changes are lost when the screen is refreshed.

It is happening in both Firefox and Safari.

I can’t repro it here or on try.discourse.org, but @erlend_sh didn’t you deal with the same thing last week?


(Pad Pors) #2

some similar issues here:


(Erlend Sogge Heggen) #3

Yeah, I’ve encountered this and received some reports about it. I think I was able to reproduce once and then it was seemingly working again.


#4

@jomaxro Will you please see if you can repro it when you get a sec?


(Joshua Rosenfeld) #5

If I’m not mistaken @erlend_sh repro’d this the other day. Will add to my list.


(Jeff Atwood) #7

We need this bug fixed, @gerhard can you have a look?


(Gerhard Schlager) #9

I fixed this today. You should get an error when you try to save an email template with missing interpolation keys.

Bonus: Changing an email template will create an entry in the Staff Log. That didn’t happen before.

While testing this I also noticed that reverting changes to an email template or site text can result in a “translation missing” error. I think I found a solution for that as well, but I’m not comfortable merging it in until someone else from the team takes a look at it.

@Pad_Pors Unfortunately it’s currently not possible to omit interpolation keys.


(Gerhard Schlager) #10

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.