Chrome OS displays as 'unknown device' on user account page

bug
1

a minor glitch, at /u/USERNAME/preferences/account, Chrome OS devices are listed as ‘? unknown device’.

User agent string typically looks like:

Mozilla/5.0 (X11; CrOS x86_64 11895.118.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.159 Safari/537.36

(Chrome OS now >1% global PC OS market share, and >20% US laptop sales; big in education)

4 Likes
2

Maybe we can detect this @nbianca?

https://developers.whatismybrowser.com/useragents/explore/operating_system_name/chromeos/

CrOS (armv|x86) perhaps as a regex match?

7 Likes
3

Now, Chrome OS devices are detected.

https://github.com/discourse/discourse/commit/8196af165d8de50e7eb0fc9282aefae37622b760

10 Likes
4

Thanks! Rebuilt with this fix and Chrome OS detection is working now.

6 Likes