Vivaldi, Windows Mobile and Edge not detected

feature
1

Hello,

I use two main OS and browsers (I paste user agents for the record):

  • Edge on Windows 10 Mobile (Lumia phone)
    Mozilla/5.0 (Windows Phone 10.0; Android 6.0.1; Microsoft; Lumia 640 LTE Dual SIM) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Mobile Safari/537.36 Edge/15.15063
  • Vivaldi on Windows 7
    Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36 Vivaldi/2.1.1337.36

But in the two Discourse sites I use, MetaBrainz running Discourse 2.2.0.beta3 and meta running Discourse 2.2.0.beta4, in Recently Used Devices section:

  • Vivaldi is seen as Google Chrome on both Discourse sites
  • Windows 10 Mobile is seen as Android Device on both Discourse sites
  • Edge is seen as Google Chrome on 2.2.0.beta3 (seems OK Microsoft Edge on 2.2.0.beta4, though)

Vivaldi does not occur anywhere in code.

For Windows Phone detection, I do see it, but maybe it’s not used in Recently Used Devices screen:

https://github.com/discourse/discourse/blob/597f1709953d2c466bf55f87efb1660d02f04a71/app/assets/javascripts/discourse/pre-initializers/sniff-capabilities.js.es6#L21

2

We don’t want to go down this path though:

image
image.png1061×877 56.9 KB

Vivaldi is at 0.05% market share, we ought to do Yandex and UC Browser well before it, and then when do we stop? At the moment to keep things simple our detection simply should stop at Opera, which technically is almost Chrome cause it runs Blink but still.

Windows mobile is almost dead, Microsoft started killing it in 2017.

The only impact of these nits are cosmetic in the list of sessions.

7 Likes
3

Oh yes, absolutely, I just wanted to note it down somewhere in case someone else is wondering why their sessions look like this.

Discourse works wonderfully good under those anyway (probably because they seem based on Chrome).

I am not expecting a fix if it’s only for the session list.
I thought maybe you were using those for stats as well, or something, so it could worth letting you know. :slight_smile:
It’s why I just wrote this under #feature (Discussion about existing Discourse features, how they can be improved or enhanced, and how proposed new features could work.) and not under #bug. :slight_smile:

1 Like