Clarification needed in Direct email delivery setup instructions

Support

AI-generated summary

A minor error was found in the Direct email delivery setup instructions for Discourse. The error is in the Letsencrypt key file setting, which uses a placeholder value (/letsencrypt/discourse.example.com/prop.ltcmp.net.key) that should be obvious to replace with the actual domain key file. nachotester pointed out the issue and suggested it be corrected to <your domain key file>. bmann also shared their experience with the issue and suggested continuing the example with /letsencrypt/discourse.example.com/discourse.example.com.key. pfaffman confirmed the correction and asked Falco to make the update, which has now been fixed with a commit to the Discourse Docker repository.

1

Thanks so much for putting together the Direct-reply-to email. I think it’s one of the most underrated features of Discourse!

The guide is excellent. However, one minor yet error-prone detail is letsencrypt key file setting. It should be very obvious that it’s a placeholder, eg <your domain key file>.

# uncomment these (and the volume below!) to support TLS 
#  POSTCONF_smtpd_tls_key_file:  /letsencrypt/discourse.example.com/prop.ltcmp.net.key <---- ???
#  POSTCONF_smtpd_tls_cert_file:  /letsencrypt/discourse.example.com/fullchain.cer
#  POSTCONF_smtpd_tls_security_level: may

It has been brought up before.

Thank you for the great work!

2

Thanks. I’ll work on this in a couple of days.

3

Yes please. This took me a LOT of time to track down. I suggest just continuing the example, so:

/letsencrypt/discourse.example.com/discourse.example.com.key

4

Ah. OK. Now I see.

Should read

 #  POSTCONF_smtpd_tls_key_file:  /letsencrypt/discourse.example.com/discourse.example.com.key

NOT

#  POSTCONF_smtpd_tls_key_file:  /letsencrypt/discourse.example.com/prop.ltcmp.net.key

I thought that github used to let me click edit to automatically make a branch to submit a PR, but it’s not working that way for some reason.

@Falco could you make the proposed update?

7

Fixed by

https://github.com/discourse/discourse_docker/commit/8d1b64de325c82bcf9395f583ac67462e001d50e