Customization in body tag won't appear in some pages

leo.proctor · 27 ديسمبر 2018، 9:46م

If I add some customization in body tag like a div as shown in below screenshot:

The div appears in normal pages, but it won’t appear in some pages like (topic not found) page: for example
https://meta.discourse.org/t/123456778888888

While other customization works as expected that is added via head Header Footer etc.

sam · 31 ديسمبر 2018، 12:48ص

This is somewhat tricky

github.com/discourse/discourse

app/views/layouts/no_ember.html.erb

a19170a4c


      
          <html lang="<%= html_lang %>">
          <head>
            <meta charset="utf-8">
            <title><%= content_for?(:title) ? yield(:title) : SiteSetting.title %></title>
            <meta name="description" content="">
            <%= render partial: "layouts/head" %>
            <%= render partial: "common/discourse_stylesheet" %>
            <%= discourse_csrf_tags %>
          
            <%= theme_lookup("head_tag") %>
            <%= yield(:no_ember_head) %>
            <%= build_plugin_html 'server:before-head-close' %>
          </head>
          <body <% if @custom_body_class %>class="<%= @custom_body_class %>"<% end %>>
            <%= theme_lookup("header") %>
            <%= build_plugin_html 'server:header' %>
            <section id='main'>
              <%= render partial: 'header' %>
              <div id="main-outlet" class="<%= @container_class ? @container_class : 'wrap' %>">
                <%= yield %>

This file has been truncated. show original

I can spot two issues here …

footer is not in footer tag. Which may be very tricky to fix if static pages add footer already.
We are missing <%= raw theme_lookup("body_tag") %>

(2) is probably very simple and safe to add… (1) is hard.

@Johani can you add this to your list to determine if (2) is safe and just do a PR for it.

Johani · 31 يوليو 2019، 7:10ص

We now lookup theme fields more consistently in all the relevant views.

Thank you for reporting the issue @leo.proctor

الموضوع		الردود	مرات العرض
Footer is missing in several places around the site Bug	3	1134	5 أغسطس 2015
Custom footer disappears on some profile pages Bug	2	674	16 يوليو 2018
Weird behavior of the topic-progress with a </body> customisation Support	4	1818	31 يناير 2019
Custom footer disappear on some pages Bug	2	528	4 مايو 2022
Custom footer disappears in group -> activity -> topics Bug	2	705	17 مايو 2018

Customization in body tag won't appear in some pages

الموضوعات ذات الصلة