Footer is missing in several places around the site


(Michael Downey) #1

Continuing the discussion from Has anyone added a custom footer to Discourse?:

Reproduce steps:

  • As an admin, add some HTML for a footer to your site. Save settings.

Expected

  • Footer will be at the bottom of the page whenever the bottom is reached (excepting infinite scrolling).

Actual:

There are several pages where the admin-customized footer HTML is not rendered:

  • error pages
  • search result pages
  • list of all tags
  • list of a specific tag
  • user leaderboard
  • Any others? (If anyone finds them please add to this topic.)

(Régis Hanol) #2

Nice catch. Will fix.


(Régis Hanol) #3

Just pushed a couple of fixes :tiger:

https://github.com/discourse/discourse/commit/35e6e5ff677e40304d3624de88147cda5b7b82f8


https://github.com/discourse/discourse-tagging/commit/846d28ffabd2ee747e1c390f157543a55f2ed191

Feel free to flag this if I missed a spot.


(Régis Hanol) #4