ganncamp
(G Ann Campbell)
November 7, 2023, 7:41pm
1
My search turns up at least a couple of topics about deleting - or not - tags. They’re old and seem to be solved.
Aand… it looks like this is a brittle feature? Because it seems to be broken again, at least on my site:
(Can others see the video? Alas it’s just a black box for me. My company’s “safe” browser strikes again, I fear.)
1 Like
Can you check if there are any details in the browser console when you click on the button?
Looks like the modal doesn’t open.
Yes, there is no issue. Do you see a black box without a play button?
1 Like
ganncamp
(G Ann Campbell)
November 7, 2023, 8:05pm
3
Hmm… it was just a black box in the post preview window, but now I do get a play button (that works!)
And yes, good call. There’s a JS error:
tag-info.js:146 Uncaught TypeError: this.get is not a function
at Object.deleteTag (tag-info.js:146:14)
at $._run (index.ts:665:23)
at $._join (index.ts:640:19)
at $.join (index.ts:362:17)
at p (index.js:156:1)
at index.js:707:1
at e.flaggedInstrument (index.js:126:1)
at index.js:706:1
at index.js:665:1
at d._triggerAction (d-button.js:117:25)
at d.click (d-button.js:87:21)
deleteTag @ tag-info.js:146
$._run @ index.ts:665
$._join @ index.ts:640
$.join @ index.ts:362
p @ index.js:156
(anonymous) @ index.js:707
e.flaggedInstrument @ index.js:126
(anonymous) @ index.js:706
(anonymous) @ index.js:665
_triggerAction @ d-button.js:117
click @ d-button.js:87
1 Like
Side-effets of
committed 10:39AM - 06 Nov 23 UTC
The motivation of this PR is to remove our dependence on Ember's 'named outlets'… , which are removed in Ember 4+.
At a high-level, the changes can be summarized as:
- The top-level `discovery` route is totally emptied of all logic. The HTML structure of the template is moved into the `<Discovery::Layout />` component for use by child routes.
- `AbstractTopicRoute` and `AbstractCategoryRoute` routes now both lean on the `DiscoverySortableController` and associated template. This controller is where most of the logic from the old top-level `discovery` controller has ended up.
- All navigation controllers/templates have been replaced with components. `navigation/categories`, `navigation/category` and `navigation/default` were very similar, and so they've all been combined into `<Navigation::Default>`. `navigation/filter` gets its own component.
- The `discovery/topics` controller/template have been moved into a new `<Discovery::Topics>` component.
Various other parts of the app have been tweaked to support these changes, but I've tried to keep that to a minimum.
Anything from `<TopicList>` down is untouched, which should hopefully mean that a large proportion of topic-list-customizing themes are unaffected.
For more information, see https://meta.discourse.org/t/282816
And fixed here
committed 11:56AM - 07 Nov 23 UTC
https://github.com/discourse/discourse/pull/22622 accidentally introduced an `@a… ction` decorator inside the actions hash, which does not work. This commit modernizes the component by removing the actions hash altogether.
You should upgrade Discourse to fix this issue!
3 Likes
system
(system)
Closed
December 7, 2023, 8:58pm
11
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.