At the bottom of a post, “post admin actions,” “edit this post,” “you’ve read this post; click to bookmark it,” “begin composing a reply to this post,” “privately flag this post,” and “share a link” are in all lowercase. “Delete Topic” is in title case.
2 Mi Piace
Er what? Screenshot because I am not seeing this?
I think he is talking about the tooltips on a post
versus
7 Mi Piace
Should this be pr-welcome’d?
1 Mi Piace
You will need to be careful, as it seems to be using the translation used in the Delete Topic button (admin wrench). So you don’t want to lowercase the translation itself.
2 Mi Piace
Hi,
I can change this. The translation for this(topic.actions.delete) is not used anywhere else. Still I think it will be better to create new translation like post.actions.delete_topic.
What do you think?
2 Mi Piace
Translation formatting errors are going to creep in. When consistency matters it might be simplest to standardise using CSS (text-transform: lowercase).
1 Mi Piace
Hi,
I tried to see if I can use the css approach but it won’t be possible currently.
Discourse uses a common button module and we pass the key for translation to it. If I change that approach, I will have to do a major cleanup for buttons which is not worth it for this change and most probably will break things somewhere. Also creating just 1 button differently to support this seems bad design.
I have created a PR with my approach of adding a new translation
https://github.com/discourse/discourse/pull/6778
Thanks
1 Mi Piace
This can be closed now. PR is merged.
3 Mi Piace