riking
June 14, 2021, 9:50pm
8
It appears that this was broken at the same time as Error page appears repeatedly after you try accessing a private page .
I believe I have a clean fix by placing the logic into the exception controller, which will allow future additions to detailed_404 to happen much smoother, if we ever decide to do so.
discourse:master ← riking:category-404-3
opened 09:47PM - 14 Jun 21 UTC
https://meta.discourse.org/t/detailled-404-for-category-page/171444/
This was… previously broken by 59ef48c0b9d70a6639a545d1c96f3cc6f93ebf2c (#11425, #11424, https://meta.discourse.org/t/error-page-appears-repeatedly-after-you-try-accessing-a-private-page/170557/).
Centralize the logic into the exception controller, which avoids the problematic bug and makes it easy to add additional detailed 404 pages in the future.
:warning: This commit is a localization break. Translators should copy the `not_in_group.title_topic` key to the `not_in_group.title_category` key, changing "topic" to "category".
4 Likes