Discobot "bookmark instruction" problem

discobot
translation

#1

Hello team.

I have been waiting for the transifex translations to be updated, but following the latest commits, I think it should work fine, and it is not working properly.

If you see this line 236

You will see the bookmark instructions by discobot to teach a user how to bookmark some message.

The same instruction on spanish version are at line: 206

But, tested now on try.discourse.org and I saw:

Ps. The interface discobot was set on “es” language selection. :es:


(Daniela) #2
Si quieres aprender más, selecciona <img src="/images/font-awesome-ellipsis.png" width="16" height="16"> debajo y <img src="/images/font-awesome-bookmark.png" width="16" height="16">  **guarda como favorito este mensaje privado**. Si lo haces, quizás haya un :gift: en el futuro!

Something wrong in your translation, you lost the URI, see:

<img src="%{base_uri}/images/font-awesome...


(Daniela) #3

@SidV I downloaded the narrative.bot.yml from transifex (version Spanish/Spain)

It seems that this version is not up-to-date, the strings are old, in fact the string for the bookmark is completely missing.

A quick fix is to upload the original file from github to transifex.

(and don’t forget to fix the URI that you lost)


#4

Did you check “es” version?

That version is OK.
I don’t know why translations did not update to github repos :frowning:


#5

Sorry for dump this.

But, I checked the last commit (22 hours ago) for “Update translations” from @neil and it didn’t have the spanish files for narrative bot. :sob:

I’m waiting that upgrade to use the bot in spanish :’(

Please tell me if you need some help to update from trasnsifex to github’s repo.
Really I don’t know how that works, but I can learn.


(Neil Lalonde) #6

Translations seem to be there:

I pulled again now, but no new translations were found.


(Daniela) #7

@neil if you try to compare the es version from github with the es version from transifex you’ll see the difference (many missing strings on github)


(Neil Lalonde) #8

So… Spanish means a lot of things: es_ES, es, es_AR, es_419, es_EC

Discourse has only ever supported one: es_ES.

But looking at Transifex, I see all these other translations that aren’t used by Discourse. Translators are doing a lot of work for nothing…

When Transifex integration was being setup, es_ES was the one. I don’t know why it was chosen since it was entirely up to the translators. Since all these other Spanish translations are being maintained, we can take pull requests for them. But the “es” translations are probably useless since we’re already mapping the es_ES ones to es. From what I remember, Rails i18n doesn’t recognize “es_ES”, which is why it had to be mapped to “es”. I’m not sure if es_AR and es_ES will work.


#9

Great ! Let’s replace es_ES version with es files.

But… at interface preferences, when a user search “pt” (for example), has got two options: pt and pt_BR

If a spanish user search “es”, did not find es_ES:

That’s reason is why I spent a lot of time translating “es” version at transifex.
Now you said to me that this version is not the correct one. OK, I’ll replace the transifex files from “es” to “es_ES”.

And all happy, IMO, when we finish this, this “es” version should be deleted from transifex.

By the way, @neil can you set me as reviewer for es_ES version at transifex?


Update: transifex es_ES version is now translated to 100%.


(Neil Lalonde) #10

I guess we have pt and pt_BR because people submitted pull requests for them. We can accept PR’s for es_AR, etc. too.

Technically, our english locale is en_US, but we map it to en, and we’ve never added translations for en_GB, en_CA, en_AU, en_IN, en_JM, etc…

Thanks for completing the es_ES translations @SidV!


(Rafael dos Santos Silva) #11

pt is Portugal and pt_BR is Brazil. There is no pt_PT, that would be Portugal too.


#12

New release, new update about this topic.

I tried again in try.discourse.org
Everything it’s :ok:

Works fine. Translations are good.
I sent some new corrections to transifex now :sunny:

We can close this thread
Thanks all for the support!


(Régis Hanol) #13