Discourse Data Explorer Import no longer works?

keegan · February 22, 2024, 9:47pm

Thanks for reporting this! It should now be resolved

github.com/discourse/discourse

FIX: Regression with `onFilesPicked` action

discourse:main ← discourse:fix-pick-files-action

opened 07:37PM - 22 Feb 24 UTC

keegangeorge

+4 -0

A regression was introduced in a previous commit (https://github.com/discourse/d…iscourse/pull/22232#discussion_r1244417291) which removed `this.onFilesPicked(files)` action because it seemed as if it was not being used. It was also causing errors in the console with usage in the composer for form templates. However, `<PickFilesButton />` in fact accepts `this.onFilesPicked` as an action passed, which is used, for example, in the Data Explorer plugin. This was apparent as imports [stopped working](https://meta.discourse.org/t/discourse-data-explorer-import-no-longer-works/295074) in Data Explorer. In this PR, we reintroduce the call to the `this.onFilesPicked(files)` action, however we wrap it in a type check so that it doesn't get called in other usages of the component such as with the form template uploader where it was previously causing errors in the console.

Topic		Replies	Views
Data Explorer json import doesn't seem to work here Data & reporting	5	268	March 18, 2024
Importing an exported json query doesn't work anymore Data & reporting sql-query	8	1938	May 22, 2020
Error thrown when importing a query in Data Explorer Bug	2	1381	April 4, 2017
Discourse Data Explorer Plugin official , data-explorer	23	78408	April 16, 2025
Data Explorer unusual error on a site on which DE only recently installed Bug data-explorer	5	650	February 9, 2023

Discourse Data Explorer Import no longer works?

Related topics