Discourse Data Explorer Import no longer works?

keegan · February 22, 2024, 9:47pm

Thanks for reporting this! It should now be resolved

github.com/discourse/discourse

FIX: Regression with `onFilesPicked` action

discourse:main ← discourse:fix-pick-files-action

opened 07:37PM - 22 Feb 24 UTC

keegangeorge

+4 -0

A regression was introduced in a previous commit (https://github.com/discourse/d…iscourse/pull/22232#discussion_r1244417291) which removed `this.onFilesPicked(files)` action because it seemed as if it was not being used. It was also causing errors in the console with usage in the composer for form templates. However, `<PickFilesButton />` in fact accepts `this.onFilesPicked` as an action passed, which is used, for example, in the Data Explorer plugin. This was apparent as imports [stopped working](https://meta.discourse.org/t/discourse-data-explorer-import-no-longer-works/295074) in Data Explorer. In this PR, we reintroduce the call to the `this.onFilesPicked(files)` action, however we wrap it in a type check so that it doesn't get called in other usages of the component such as with the form template uploader where it was previously causing errors in the console.

Topic		Replies	Views
Data Explorer json import doesn't seem to work here Data & reporting	5	262	March 18, 2024
Discourse Data Explorer Plugin official , data-explorer	6	74221	November 4, 2024
SQL Error during import Installation	19	2262	May 3, 2015
Data Explorer cannot export to CSV Bug	12	1590	October 5, 2017
Restore failing- possible Data Explorer issue Installation	21	2083	December 9, 2019

Discourse Data Explorer Import no longer works?

Related Topics