Discourse Gifs component

Thank you so much @Falco you’re awesome :sunglasses: it almost impossible I know that is freaking hard to do it so yeah huge :+1:
Works great :slightly_smiling_face:

Only one thing I noticed when I search first time a gif it works great after if I search other term than it freezes everything.

2 Likes

Which browser are you using? Not able to repro this here.

(note the flashing party while typing is a known issue with the discourse composer, not something we can easily fix sadly)

4 Likes

Hi Sam,

The issue is on iOS.

I tried to upload a screen video but too big.

So I type Happy in search than wait while loading completely the gifs. Than start delete characters to search another. And it frozen. Only works is full refresh the page.

3 Likes

I think that is enough info for @Falco he was battling with iOS today and is not quite done with his fixes.

6 Likes

Thank you so much your awesome guys :slightly_smiling_face:

3 Likes

One more thing after post a gif it downloading all images (actually it downloads the full mp4 video gif) from tenor somehow I guess and break the gif.

So I just added media.tenor.com to disable image download domains setting. It seems now working well :slightly_smiling_face:

2 Likes

Yes, because of the hack for iOS devices it triggers the download feature now. So you must add the tenor domain to the exception list.

3 Likes

I fixed playback in iPadOS.

And while I can reproduce the freeze @dodesz, but since Safari is outright crashing there is not much I can do as it is not a simple exception but the browser is completely locking up. I made the markup simpler to reduce the number of elements, but it still crashes after 5 searches or so.

6 Likes

I noticed freezing as well. It was on this website while I was editing a thread with a GIF. The whole browser tab froze twice on me, after I deleted the GIF in the composer it stopped freezing. I’m on the latest version of Firefox with Windows 10 desktop.

2 Likes

In this forum it works perfectly, but not in mine, it just appears as a motionless image in the post. :frowning_face:

1 Like

Did you upgrade Discourse recently too?

I believe you need to be at least as recent as this commit to be able to use it : FEATURE: Allow video tag attributes for video gifs · discourse/discourse@7253422 · GitHub

2 Likes

Thanks, I do NOT have much knowledge of the subject, how do I install that JS?

1 Like

The theme-component had several updates so check if you have any pending updates for it.

2 Likes

Thanks :heart:

In fact, today I did the update of the theme-component, possibly the problem is what @Steven mentioned, I’m going to check.

1 Like

You need to visit /admin/upgrade on your site and update to latest.

5 Likes

Thank you so much :heart: :wink:

1 Like

You have made me so happy today @Falco.

5 Likes

Added a pause on blur and some optimistic blocking filter for media with audio.

5 Likes

Seem to me to be a positive pausition to take.

5 Likes

Thanks added to my community

3 Likes