I’ll confirm this one. I just had a beta site send emails to the entire user base even though the setting is at non-staff. Emails went out to 1,000 people who shouldn’t know the site exists yet.
Edit: Following up here. I decided to break the email configuration on this beta site to get emails to stop. I could trigger emails to non-staff users pretty easy with mentions and such even though the disable emails setting was at non-staff.
I don’t pretend to understand how things work at this level (maybe there are tests elsewhere that I don’t know about), but I don’t see how this code would skip sending if disable_emails was staff_only. Also, if I remember correctly, the old value used to be true/false, so it looks like if it had been set to true it would fail matching the yes in the test below (or maybe that would have been fixed in a migration somehow or Rails magically thinks that true and yes are the same?).