Thanks, I meant to update this when we fixed it. It used to work without the !important but now that’s indeed necessary. It maybe ought not be required, but it’s a feasible answer.
Well, !important is a hack. Should work until it… well… doesn’t (when it breaks something else).
If you don’t want !important, you need to be careful about the specificities of your CSS rules, which must be higher than the specificites of the original stylesheet. But this is not at all foolproof because the original stylesheet can always change specificity with more terms and your styles will still break.
So better stick to !important since nothing is foolproof anyway.
And potentially a feature request, is it possible to restrict the emoji-set based on specific user-based features? IE give users of X group access to Y set of emojis?
Are you using it with Babble by any chance? Babble’s affected by the same trouble as retort (since they both have emoji pickers), which I’m looking into now. A fresh install with just Retort works just fine as far as I can tell.
I am removing a really old way of doing events in Discourse right now to help us upgrade Ember. I noticed that retort does TopicRoute.on('setupTopicController') which is being removed. Retort will need to be updated to do this in another way.
I would normally submit a PR but I noticed that the messageBus events are not being cleaned up either. I would recommend moving this logic to a custom component in a plugin outlet inside topic. The messageBus definitely needs to be unsubscribed when it’s not shown (and if it’s ever re-shown and hasn’t been cleaned up before.)
Still have faded window on mobile(haven’t tested desktop). Still get faded screen with no emoji select window. However can tap any where to get back to forum without closing window.
Thank you again for your efforts to fix your awesome plugin.
I can confirm that everything’s working as expected on the latest Discourse / Retort versions on https://discourse-babble.com, so there must be something different about your settings / customizations. Anything spring to mind as a possibility?
Okay Retort is confirmed to work with no restricted Emoji is not on. If Restricted is turned on the emoji retort window does not open. Just greys/dulls screen.
Although it’s working fine for us overall, the newest update introduced a noticeable lag, a second or two before the items show up after clicking to add a reaction.