Email template titles not translated

[claas (Claas Aug.)]

I noticed two translation problems with the Email templates in the Administration → Customize → Email templates section.

1. Titles of email templates are not translated:

Clarification: The title of an email template is not its subject.

This is because the AdminEmailTemplateSerializer only “titleizes” the keys of the email templates (e.g. system_messages.bulk_invite_failed becomes Bulk Invite Failed) here:

https://github.com/discourse/discourse/blob/5dbd6a304bed5400be481d71061d3e3ebb4d6785/app/serializers/admin_email_template_serializer.rb#L8-L10

2. Four email templates are missing in I18n:

• system_messages.email_reject_destination
• system_messages.email_reject_post_error
• system_messages.email_reject_post_error_specified
• system_messages.email_reject_trust_level

Update: Looks like artifacts, as not referenced anywhere (added links to GitHub search).

[claas (Claas Aug.)]

Here’s the PR for solving the first problem:

https://github.com/discourse/discourse/pull/4636

[claas (Claas Aug.)]

@claas

system_messages.email_reject_destination

Was replaced by email_reject_bad_destination_address here.

@claas

system_messages.email_reject_post_error

Was removed here.

@claas

system_messages.email_reject_post_error_specified

Was replaced by email_reject_invalid_post_specified here.

@claas

system_messages.email_reject_trust_level

Was replaced by email_reject_insufficient_trust_level here.

In short: We can remove these.

Remove unused email templates.

P.S.: This advice helped.