Missing `emails.incoming.errors` translations

tomtjes · April 9, 2023, 4:29pm

In Admin > Emails > Rejected I have an email with the following error:

Error
Email::Receiver::OldDestinationError
translation missing: en.emails.incoming.errors.old_destination_error

While I messed with translations for my site, I think this is not just an issue for me. The server.en.yml on Github seems to indeed lack this translation.

gerhard · April 19, 2023, 7:27am

I’m moving this into the bug category, so that it doesn’t get lost.

We should fix this and also, if possible, add a spec or linting rule to ensure that every error in Email::Receiver has a corresponding translation. The note in that file certainly isn’t enough.

github.com

discourse/discourse/blob/f63d18d6ca20861b8580f3b52d1575c15bfe7271/lib/email/receiver.rb#L7-L9


      
          # If you add a new error, you need to
          #   * add it to Email::Processor#handle_failure()
          #   * add text to server.en.yml (parent key: "emails.incoming.errors")

Also, we need to check if other translations are missing.

github.com

discourse/discourse/blob/437b73e322d9f368f1ba886a7a1a6087806dda9d/config/locales/server.en.yml#L127-L146


      
          errors:
            empty_email_error: "Happens when the raw mail we received was blank."
            no_message_id_error: "Happens when the mail has no 'Message-Id' header."
            auto_generated_email_error: "Happens when the 'precedence' header is set to: list, junk, bulk or auto_reply, or when any other header contains: auto-submitted, auto-replied or auto-generated."
            no_body_detected_error: "Happens when we couldn't extract a body and there were no attachments."
            no_sender_detected_error: "Happens when we couldn't find a valid email address in the From header."
            from_reply_by_address_error: "Happens when the From header matches the reply by email address."
            inactive_user_error: "Happens when the sender is not active."
            silenced_user_error: "Happens when the sender has been silenced."
            bad_destination_address: "Happens when none of the email addresses in To/Cc fields matched a configured incoming email address."
            strangers_not_allowed_error: "Happens when a user tried to create a new topic in a category they're not a member of."
            insufficient_trust_level_error: "Happens when a user tried to create a new topic in a category they don't have the required trust level for."
            reply_user_not_matching_error: "Happens when a reply came in from a different email address the notification was sent to."
            topic_not_found_error: "Happens when a reply came in but the related topic has been deleted."
            topic_closed_error: "Happens when a reply came in but the related topic has been closed."
            bounced_email_error: "Email is a bounced email report."
            screened_email_error: "Happens when the sender's email address was already screened."
            unsubscribe_not_allowed: "Happens when unsubscribing via email is not allowed for this user."
            email_not_allowed: "Happens when the email address is not on the allowlist or is on the blocklist."
          unrecognized_error: "Unrecognized Error"