Email types not translated

(Claas Aug.) #1

I have noticed that email types in Administration -> E-Mails are not translated:

(Claas Aug.) #2

This one is a bit trickier, but here’s what I found out.

  1. The displayed email type comes from this line in the template (for the Sent page):
  2. The list shows EmailLog records, which have an email_type field defined here:
  3. EmailLog records are created in the jobs NotifyMailingListSubscribers and UserEmail.
  4. UserEmail jobs (and CriticalUserEmail jobs, which are a subtype) are queued at different locations with mostly hardcoded email types (found via grep -R "user_email" .):

(This should be it.)

In general, it would be a good idea to collect the complete list of valid email types (not to be confused with the email template types) at a central place and make these translatable (even though plugins may send emails as well, I suppose, therefore we probably cannot reject email keys that are not in this list, which would assert that this list is to be kept complete).