Embed: dates are not localized

probus · 27.Апрель.2015 14:42:06

Dates always show up in default (US) locale in embedded comments.

downey · 27.Апрель.2015 15:56:14

Hmm. What do you mean “embedded comments”? Can you provide some detailed steps to reproduce this bug?

probus · 28.Апрель.2015 05:14:57

Switch Discourse locale to any other than English
Embed Discourse comments on a website
UI is localised but dates are not on the embedded (iframe) comments

probus · 12.Август.2015 11:42:06

Any updates on this?

probus · 02.Декабрь.2015 09:47:49

Still in English, but we can now at least hide them with CSS.

probus · 15.Апрель.2016 13:45:37

Happy anniversary!

fantasticfears · 15.Апрель.2016 18:57:02

Darkness leads me to this bug under the pale moonlight

But as a general tip, it would be definitely better if there is a link or screenshots. I can hardly understand what you are talking about if I haven’t translated the documentation

Embed comments:

The problem is in embed/comments.html.erb:

github.com/discourse/discourse

app/views/embed/comments.html.erb

main


      
              <%= link_to(I18n.t('embed.start_discussion'), @topic_view.topic.url, class: 'button', target: '_blank') %>
            <% elsif @reply_count >= 10 %>
              <%= link_to(I18n.t('embed.continue'), @second_post_url, class: 'button', target: '_blank') %>
            <% end %>
            <span class='replies'><%= I18n.t('embed.replies', count: @reply_count) %></span>
          </header>
          
          <%- if @topic_view.posts.present? %>
            <%- @topic_view.posts.each do |post| %>
              <article class='post<%- if post.trashed? %> deleted<% end %>' id='post-<%= post.id.to_s %>'>
                <%= link_to embed_post_date(post.created_at), post.full_url, title: post.created_at.strftime("%B %e, %Y %l:%M%P"), class: 'post-date', target: "_blank" %>
                <%- if post.reply_to_post.present? && !post.cooked.index('aside') %>
                  <%= link_to I18n.t('embed.in_reply_to', username: post.reply_to_post.username), post.reply_to_post.full_url, 'data-link-to-post' => post.reply_to_post.id.to_s, :class => 'in-reply-to', target: "_blank" %>
                <%- end %>
          
                <div class='author'>
                  <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank"><img src='<%= post.user.small_avatar_url %>' alt=''></a>
                </div>
                <div class='cooked'>
                  <h3 class='username'>
                    <a rel='nofollow' href='<%= Discourse.base_url %>/u/<%= post.username %>' target="_blank" class='<% if post.user.staff? %>staff<% end %><% if post.user.new_user? %>new-user<% end %>'><%= post.user.username %></a>

then ember_helper.rb:

github.com/discourse/discourse

app/helpers/embed_helper.rb

main


      
          # frozen_string_literal: true
          
          module EmbedHelper
            def embed_post_date(dt)
              current = Time.now
          
              if dt >= 1.day.ago
                distance_of_time_in_words(dt, current)
              else
                if dt.year == current.year
                  dt.strftime I18n.t("datetime_formats.formats.short_no_year")
                else
                  dt.strftime I18n.t("datetime_formats.formats.no_day")

The fix can be either using the FreedomPatches::Rails4.distance_of_time_in_words, I18n.localize(dt, format: I18n.t("datetime_formats.formats.short_no_year")) or replace the link by a different translation string as the digest email.

; I don’t quite understand the current status of server time formats so I won’t fire PR here.

weber-s · 27.Февраль.2024 15:34:32

Здравствуйте,

Я столкнулся с той же проблемой.

Вижу проблему с локализацией здесь, так как потенциально ни один пользователь не подключен, и поэтому сложно определить его локаль… но может ли это быть настройкой? Для экземпляра Discourse, ориентированного только на одноязычное сообщество, это имело бы смысл!

JammyDodger · 28.Февраль.2024 08:23:53

Похоже, это существует уже довольно давно. Интересно, стоит ли это относить к категории #feature request, а не к bug bucket.

Lhc_fl · 22.Июль.2024 10:44:47

Я отправил исправление здесь:

github.com/discourse/discourse

UX: Use localized time format in embedded comments (#28014)

main ← ux-localize-embed-posts

merged 10:42AM - 22 Jul 24 UTC

Lhcfl

+2 -2

Previously, the time format for embedded comments was hardcoded. This commit cha…nges it to the time format defined in I18n. Related meta topic: https://meta.discourse.org/t/embed-dates-are-not-localized/27997/ ## Screenshot: before: ![image](https://github.com/user-attachments/assets/b7e2d411-d7ca-4fd9-877a-fe6c3ca6ba55) after ![image](https://github.com/user-attachments/assets/52099768-6459-4108-864b-56befbe41c43)

Lhc_fl · 24.Июль.2024 10:45:08

Эта тема была автоматически закрыта через 2 дня после последнего ответа. Новые ответы больше не принимаются.

Тема		Ответов	Просм.
Embedded comments dates are still not localized Bug embedding	0	27	14.04.2026
Insert Date Timezone is always UTC ; my Timezone is ignored Support	23	3708	21.12.2019
Wrong time when using the date picker: bug? Bug	21	1742	06.12.2020
Last version v2.3.0.beta10 +23 update. time of post not show Bug	9	1296	22.06.2019
"Error Embedding" comments Support	16	2304	04.05.2022

Embed: dates are not localized

Связанные темы