Emoticon button not working anymore (because of babble plugin)

[Sylvain7]

Since the last update ( v1.9.0.beta13 +31) , the emoticon button is not working anymore (it doesn’t trigger anything on click)

[jomaxro (Joshua Rosenfeld)]

Hmm…I can’t reproduce this on Meta or on Try (emoji panel opens fine), so this is likely due to a plugin or customization. Do you have any non-official plugins, or JS/CSS customizations?

[Sylvain7]

css custom and some plugin (babble stable and who’s online)

Got this error on my console :
TypeError: this.didUpdateAttrs is not a function

    at s.triggerAttrUpdate (_plugin-third-party-42bd0246fcf849476b5137f48af823bf116e50c7b77ce1c6b0c75638a708aa38.js:1380)
    at Object.t [as applyStr] (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:49256)
    at Object.f [as sendEvent] (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:29157)
    at e.flush (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:32462)
    at g (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:33020)
    at Object.y [as changeProperties] (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:33045)
    at Object.r [as setProperties] (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:34096)
    at setProperties (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:45949)
    at n.update (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:24456)
    at t.evaluate (_ember_jquery-a8dcbd325e04410f036f2a791d66d8316c48c5387acdd914de99a5dd6afb3cd3.js:10981)```

[jomaxro (Joshua Rosenfeld)]

@gdpelican @david do you recognize this error?

[Sylvain7]

I just disable Babble and still have the issue. Same for Who’s Online.

Edit : Same problem on mobile version

[zogstrip (Régis Hanol)]

You should use the safe mode rather than manually disabling plugins one by one, it’s easier & faster

Use Safe Mode to troubleshoot issues with themes and plugins

Discourse has a “JavaScript Safe Mode”, where any user can use to isolate the root cause of a JavaScript issue caused by plugins, themes or theme components. To access safe mode go to: http://your-site-name/safe-mode for example this is the safe mode for our demo site: https://try.discourse.org/safe-mode [safe mode options] [safe mode is enabled] To exit safe mode simply close your browser tab When entering safe mode you can select between: Disable all themes and theme-components …

[david (David Taylor)]

I don’t recognise it, and I can’t think why who’s-online would affect the emoji picker. But then again more surprising things have happened before

As @zogstrip said, safe mode is the best way to check. Disabling a plugin does not completely remove it.

[Sylvain7]

I just tried safe mode disabling only non-official plugins and it works. Thanks @zogstrip

So it comes from Babble or Who’s Online.

@gdpelican || @david this could help you ? :

TypeError: this.didUpdateAttrs is not a function

[dax (Daniela)]

Because Babble is currently broken and have problems with emoji picker, I propend for it:

https://meta.discourse.org/t/babble-a-chat-plugin/31753/691?u=trash

[Sylvain7]

ok thanks. I’ll remove it and come back here to make my report

[schungx (Stephen Chung)]

triggerAttrUpdate is from the old code of Babble. It attempts to call an emoji picker function that changed name due to some commit.

I have a PR on Babble that fixes this.

The Babble topic on plugins should have the URL for my PR for you to pull in.

I use whosonline and bubble together with no prob.

[Sylvain7]

Rebuilding app with your fork…

[Sylvain7]

It works ! Thanks a lot @schungx !

Topic can be closed