Empty oneboxes because linked post contains github onebox

blake · July 27, 2023, 7:08pm

A fix has been created for this

github.com/discourse/discourse

FIX: Internal oneboxes with github links

discourse:main ← discourse:fix-internal-links-with-gh

opened 04:01PM - 27 Jul 23 UTC

oblakeerickson

+56 -1

Internal oneboxes to posts that contained oneboxed github links to commits or PR…s with long enough commit messages to have the `show-more` and the `excerpt hidden` classes in their html were being stripped of their content resulting in empty internal oneboxes. see: https://meta.discourse.org/t/269436 This fixes a regression introduced in: 0b3cf83e3c7d03c2dcd54f86de60efe32f385a44

Topic		Replies	Views
Odd behavior when sharing topics with hidden content at the top or that start with links UX onebox	3	639	September 11, 2023
Incorrect or failing oneboxes for links to other discourse instances Bug	17	2122	August 17, 2017
Link resolution (Onebox) stopped working Bug	8	819	August 8, 2022
Twitter oneboxes and links broken now that login is required Bug	13	2921	May 8, 2024
Internal links not oneboxing in private messages Bug	11	2506	February 21, 2018

Empty oneboxes because linked post contains github onebox

Related Topics