Empty oneboxes because linked post contains github onebox

blake · July 27, 2023, 7:08pm

A fix has been created for this

github.com/discourse/discourse

FIX: Internal oneboxes with github links

discourse:main ← discourse:fix-internal-links-with-gh

opened 04:01PM - 27 Jul 23 UTC

oblakeerickson

+56 -1

Internal oneboxes to posts that contained oneboxed github links to commits or PR…s with long enough commit messages to have the `show-more` and the `excerpt hidden` classes in their html were being stripped of their content resulting in empty internal oneboxes. see: https://meta.discourse.org/t/269436 This fixes a regression introduced in: 0b3cf83e3c7d03c2dcd54f86de60efe32f385a44

Topic		Replies	Views
Odd behavior when sharing topics with hidden content at the top or that start with links UX onebox	3	653	September 11, 2023
Incorrect or failing oneboxes for links to other discourse instances Bug	17	2161	August 17, 2017
Creating rich link previews with Onebox Using Discourse onebox , how-to	0	19030	September 26, 2018
Disable link preview feature? Support	8	2144	June 22, 2023
Onebox: rewrite Github links to specific commit? Feature	8	1661	March 8, 2015

Empty oneboxes because linked post contains github onebox

Related topics