Moin
June 23, 2023, 5:03pm
1
So here it is:
The onebox for posts containing a github onebox do not show any text of the post. Example:
Now we have a site setting to disable the username.
Seems it worked in February because this post has a onebox with text
Per-user opt-in of appending the username on link sharing - #4 by JammyDodger
The onebox is even empty if there is text in front of the github onebox
This has been fixed in
Thank you for the report @GregoryS
4 Likes
I’ve come across this a couple of times myself now while quoting posts with fixes/commits. It does make using the onebox method a little unreliable. I’ll shift this over to bug and see if we can get someone to take a look.
3 Likes
blake
(Blake Erickson)
July 27, 2023, 7:08pm
12
A fix has been created for this
discourse:main
← discourse:fix-internal-links-with-gh
opened 04:01PM - 27 Jul 23 UTC
Internal oneboxes to posts that contained oneboxed github links to
commits or PR… s with long enough commit messages to have the `show-more`
and the `excerpt hidden` classes in their html were being stripped of
their content resulting in empty internal oneboxes.
see: https://meta.discourse.org/t/269436
This fixes a regression introduced in:
0b3cf83e3c7d03c2dcd54f86de60efe32f385a44
6 Likes
blake
(Blake Erickson)
Closed
July 31, 2023, 2:00pm
14
This topic was automatically closed after 2 days. New replies are no longer allowed.