nathank
(Nathan Kershaw)
January 9, 2024, 4:17am
1
It is great to have Events posted in PMs displayed in the upcoming-events calendar. However, they aren’t currently visible to users unless hovered over.
In the HTML, the border-color and color are #undefined
; this is likely a regression due to the recently introduced category and tag colors (and picker) for the plugin - which I love by the way!!
Here is the rendered HTML:
<a class="fc-day-grid-event fc-h-event fc-event fc-start fc-end" href="/t/-/30588/1" style="background-color:unset;border-color:#undefined;color:#undefined">
<div class="fc-content" style="max-height: 32px;">
<span class="fc-time">3p</span>
<span class="fc-title" style="overflow: hidden; white-space: pre-wrap;">Chat re NAHSTIG (record)</span>
</div>
</a>
2 Likes
renato
(Renato Atilio)
January 9, 2024, 10:14pm
3
Hey @nathank , thanks for the report!
It’s indeed a regression, you are also using the include_expired_events_on_calendar
site setting, right?
The issue is that we were creating an outline of the background color for expired events, but events in PMs don’t have a background color set at all.
This PR should fix it:
discourse:main
← discourse:upcoming_events_pm_expired_hidden
opened 10:05PM - 09 Jan 24 UTC
Fixes https://meta.discourse.org/t/events-in-personal-messages-are-present-in-th… e-upcoming-events-page-but-not-visible/290950.
In addition to the fix, this PR changes the expired events to be displayed with 30% opacity (same as Google Calendar) instead of the previous outline approach.
![image](https://github.com/discourse/discourse-calendar/assets/3530/27778f20-9b70-446c-b7a1-b4dcf15494bb)
It also replaces the outline style for expired events with a simple opacity.
5 Likes
sam
(Sam Saffron)
Closed
January 19, 2024, 10:36pm
4
This topic was automatically closed after 10 days. New replies are no longer allowed.