External link to undefined in suggested topics

While reading through Meta, I saw this:

Notice that the Hetzner VPS topic is shown to be a link to undefined.

The topic itself looks fine:

My suspicion is that the domain is missing in the suggested topics payload, triggering the JavaScript payload to return undefined.

8 Likes

I saw that yesterday too. Only because while scrolling I fat-finger tapped it and got an error page which made me look. I was going to screen capture it if I saw it again and then post about it. I kept an eye out for it, and when the topic got another reply it again showed in my suggested - but - it showed “hetzner” and not “undefined”.

So it appears that not only was the link text not getting into Suggested, but neither was the link URL. As for it being OK the second time, I don’t have any idea.

* I can’t recall if it was a new or unread, but I’m leaning towards it having been a new.

Aha yes I just brought this to @neil’s attention as well.

Hmm, I’m pretty sure it used to work. Added to my list.

3 Likes

Should be fixed now.

https://github.com/discourse/discourse/commit/179ecee11e28325b301096770ab819adf433c5f3

5 Likes