Fallback to English locale doesn't work when English string is blank

@zogstrip There’s another regression with the new I18n fallback.

It’s not possible to translate strings in Transifex that are blank in the English locale files. Transifex simply ignores them. Up until now this wasn’t a problem since Discourse always used the blank strings from the English locale files, but that doesn’t seem to work anymore.

For example, desktop_notifications.currently_enabled exists only in client.en.yml and it is blank.

https://github.com/discourse/discourse/blob/master/config/locales/client.en.yml#L565-L568

That’s how it currently looks with the German locale:

2 Likes

It’s now fixinated :strawberry:

https://github.com/discourse/discourse/commit/b20b568039ca83334ab0eb5354ec47728b61fded

3 Likes

This topic was automatically closed after 2 hours. New replies are no longer allowed.