First-added bookmark doesn't show up until refresh

For me, if I start with zero bookmarks, and add at least one, it takes a full page refresh before it shows up in /users/(username)/activity/bookmarks.

Personally I really dislike that page, think it has plenty other issues when it comes to dealing with bookmarks. I exclusively use https://meta.discourse.org/bookmarks to work thorugh my bookmarks.

Then keyboard shortcuts to enable and disable then (j k and b to toggle)

I find it completely cramped, compare:

to

  • no way to sort
  • too much info
  • too much stuff on page
  • no blue circles

That said, what is the exact repro here?

2 Likes

Wow, I didn’t even know that page existed. Should the bookmark links take you to that first page instead, and the profile section be removed?

Just did another test; turns out it’s not just the first bookmark.

Repro:

  1. Take note of your bookmarks list (The one under your avatar menu)
  2. Go into a topic and bookmark the top/first post
  3. Click on avatar in top right => Bookmarks
  4. Latest bookmark doesn’t display

This also happens with removing bookmarks.

1 Like

Yeah, something weird is cached here, @eviltrout can you have a look.

The plan is to have “bookmark” be a search filter and integrate it into the advanced search page, we will get there eventually.

1 Like

Here’s a fix for the caching issue:

https://github.com/discourse/discourse/commit/f87fc98411e35f0d44a0a2076a30fb509ce0f804

3 Likes