Flag action messages sent out where they shouldn't be

The problem is kind of hard to describe, so I’ll get right to the repro steps in hopes that it will explain what’s going on:

Have user0 send a message to user1 about their post through the flagging button.
Have user2 flag the post by user1.
Agree with the flag and hide the post.

User0 will in the message they sent to user1 receive a

Thanks for letting us know. We agree there is an issue and we’re looking into it.

from the moderator who agreed with the flag.

This also happens if you delete the post from the topic page, only then User0 will see

Thanks for letting us know. We agree there is an issue and we’ve removed the post.

3 Likes

I can reproduce the issue on try. The PM sent from the flag queue ends up in the same PM as the message from user0.

4 Likes

Hmm is this a new bug related to recent flagging work @eviltrout?

probably select related I will check @eviltrout

3 Likes

Let me know if the bug isn’t in select.

Did this get fixed @joffreyjaffeux?

It’s still here, I can confirm it’s not select-kit. I think I tried it months ago, but not sure I gave the msg to robin. Anyways, I can try to fix it this week, don’t know much about our flagging code server side, good opportunity.

3 Likes

@maja fixed it

https://github.com/discourse/discourse/pull/6100

5 Likes

This topic was automatically closed after 18 hours. New replies are no longer allowed.