Format numbers depending on selected locale


(Gerhard Schlager) #1

Continuing the discussion from Is there a way to translate numbers e.g. "1.3K" in the "Views" column?:

Looking at the code I noticed that numbers aren’t formatted using the locale configured by the user or administrator.
This can be seen at the reply and view counts. On a German locale it looks like this:

But it should look like this:

In German we use a comma as decimal separator. And of course, as @downey already mentioned the “K” should be a lowercase “k”. :wink:

The missing localization of numbers can also be seen in the poll plugin. The average rating uses the English decimal separator…

Could we use a library like FormatJS or Numeral.js in order to format numbers? Looks like not all major browsers support Intl.NumberFormat yet. :frowning:

Is there a way to translate numbers e.g. "1.3K" in the "Views" column?
(Sam Saffron) #2

hmmm why do we need to pull a whole new library in for this, we already have … /lib/locale/en.js etch… why not just add another method there.

(Gerhard Schlager) #3

Yeah, I guess adding another library isn’t the best option. In an ideal world we could just use Intl.NumberFormat, but of course Safari and all those mobile browsers lack support for it. :angry:

But FormatJS looks promising. It’s using a polyfill for Intl, integrates well with Ember and I’m quite sure it would be possible to replace moment.js with it too. (Ok, moment.js is currently used for parsing and calculating dates, so replacing it is probably not an option.)

Anyway, we need some kind of solution for this. If it’s just a “simple” function in those lib/locale scripts, that’s fine with me too.

(Gerhard Schlager) #4

Looks like there’s already some code that could handle localized number formats. It’s just not used…

(Régis Hanol) #5