Formatting toolbar


#108

New version available, I fixed the incompatibility of some icons with the latest version of Discourse (that includes FontAwesome 5).

It was easier that I thought, but if you have any issue, let me know

I also changed the icon of the color’s button : instead of the paint brush, we will use the palette. Here are all the icons available:

I think it suits the button better.


If you have a fork on this plugin with custom buttons, the update is pretty easy, you just have to edit your plugin.rb file (example : line 20 to 27 : discourse-formatting-toolbar/plugin.rb at master · iunctis/discourse-formatting-toolbar · GitHub)

You have to register any icon you use. Search for your icon here : Icons | Font Awesome

If the icon is in ‘solid’ category, add :
register_svg_icon "fa-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "fa-underline" if respond_to?(:register_svg_icon)

If the icon is in ‘regular’ category, add
register_svg_icon "far-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "far-address-book" if respond_to?(:register_svg_icon)

If the icon is in ‘brand’ category, add
register_svg_icon "fab-icon_name" if respond_to?(:register_svg_icon)
ex : register_svg_icon "fab-apple" if respond_to?(:register_svg_icon)


#109

I just installed the plugin on the v2.2.0.beta7 and i have a problem: line spacing between paragraphs collapse when using text formatting: [right], [left], [center], [justify]

See the following example:

The preview on the right window is correct. But then… see next post


#110

After Reply, the text appear correctly first, but after 1-2 seconds the line spacing between the two paragraphs collapses.


#111

Thanks for the feedback, I pushed a fix. Let me know if it works well

For the previous posts, you might need to do a Rebuild HTML to update the code.

image

image


#112

Hi Steven.
No, it doesn’t work. After rebuilding HTML line spacing disappears after a fraction of a second.

2qbhia


#113

My fault! After rebuilding app it works. Thank you Steven.

I love this plugin.


#114

I found another bug. After justifying the text there is an additional line spacing. I’m working with V2.2.0.beta8.

Bug


#115

The behaviour is different from the preview and the cooked post (on preview, it adds the <p> tags for each bbcodes, not on cooked), I don’t really know where it comes from, I don’t know if it’s something I can fix on my part

edit : wait I have an idea, I can fix it in a few hours


#116

Hi Steven, if I put only one [right] in the first line and a [/right] at the end of the last line, it works correctly.


#117

I did a little upgrade to prevent this different behaviour between preview and cooked post. I should have thought about that before :man_facepalming:

I’ll check the source of the bbcodes later, maybe I can do something better than a css fix, but it should be good for now

Thanks for your feedbacks