Group username search empty-search message is wrong

When searching for a user by username or email address with a group’s search box, the message “There are no members in this group” is returned if there are no matches:

There are 50 members in the group. There just isn’t a member with the username ‘jim’.

A simple fix for this would be to just hardcode in a better error message. For example something like “No members match your search term.” Would that be a good enough fix?

Edit: I see the problem now. The message “There are no members in this group” is not a response to the search, it is what is displayed on a group’s members page when no members are returned. That happens here: discourse/group-index.hbs at main · discourse/discourse · GitHub. Fixing it would require more than just a copy change.


This should take care of it:


This topic was automatically closed after 2 days. New replies are no longer allowed.