Guest Gate Theme Component

Of course.

Forum is located here
Thank you…

1 Like

Thanks :slightly_smiling_face: It seems the component broken a bit. There was some modal changes in core. I’ll check this and try to fix.

4 Likes

Thank you very much.

1 Like

Hello, I’ve merged a quick fix but I think it needs more care in the future… Please update the theme component :slightly_smiling_face:

4 Likes

Thank you very much @Don
:bouquet:

1 Like

Unfortunately, this component does not work correctly now when you enable Experimental Lightbox[1] (enable experimental lightbox setting).

Whenever you have gate show when thumbnail clicked setting with experimental lightbox (which it seems soon to become default one), and click at thumbnail, the image will open in the lightbox successfully, while custom gate message will remain in the backrgound.

The solution is to not enable experimental lightbox for now. Hope this report helps updating the Component to properly catch new lightbox initialization.


  1. discussion topic ↩︎

2 Likes

Hello :wave:

Thanks for the report! I’ve added compatibility with new lightbox too. :slightly_smiling_face:

4 Likes

We can confirm the issue is now fixed. Thank you a lot! :black_heart:

1 Like

I merged this update: Migrate Guest Gate Modal to component based API by VaperinaDEV · Pull Request #20 · VaperinaDEV/discourse-guest-gate-theme-component · GitHub

2 Likes

Very similar to what I’ve been doing today @Don, funnily enough!

2 Likes

hello,don,Thanks for developing this component, but I’m having incompatibility issues enabling it on my website.

The version is 3.1.1,I don’t know where the problem is. Can you help me analyze it?I think this component is very good and I want to enable it.

2 Likes

@go_ahead I just installed it and it’s working as expected with no problem. Can you see if there are any errors in your console log?

1 Like
Guest Gate Theme Component theme/component is throwing errors:
Error: Could not find module `discourse/components/modal/login` imported from `discourse/theme-7/components/modal/guest-gate`

Is this an error log? Thank you very much for your reply.

2 Likes

oh you’re on 3.1 and there was this.

:thinking: I wonder if it’s because those modal changes in core haven’t been migrated to your instance yet? are you self-hosted?

@Don just recently merged this update and I suspect that may be related. I am sure he will be able to help :slight_smile:

2 Likes

Yeah, I am afraid this is the case. This theme component seems not working on stable version yet. Now the tests-passed branch needed the update but it breaks on stable. Should I create a stable version of the theme component? :thinking:

1 Like

Stable support would be appreciated :heart:

1 Like

Hello :wave:

I’ve made a new branch (stable) which is compatible (I reverted the latest update) with stable Discourse. :+1:

To install the stable version :arrow_down_small:

  1. Paste the repo url: https://github.com/VaperinaDEV/discourse-guest-gate-theme-component

  2. Click Advanced… button

  3. Add Branch name: stable

3 Likes

Hiii this pluging doesnt work anymore on the latest version, i have this error in the console:
[PLUGIN discourse-solved] Deprecation notice: Importing getOwner from discourse-common/lib/get-owner is deprecated. Use import { getOwner } from '@ember/application', or if you still need the fallback shim, use import { getOwnerWithFallback } from 'discourse-common/lib/get-owner';. [deprecated since Discourse 3.2] [deprecation id: discourse.get-owner-with-fallback]

do you have a solution to go back to a previous version so the pluging is working?

or an update soonish?

it game changer for the project i want to do :slight_smile:

thnak guys!

What is your Discourse version precisely?

1 Like

this version: