Icon deprecation warnings causing rate limiting issues

We’re seeing more and more of this lately:

Themes and plugins are causing lots of “FA icon deprecation” warnings:

image

and I have seen two different kind of responses to this: “don’t worry it’s just a warning” and “if you want to get rid of them, just fix the theme or plugin” (which is not always easy).

So, let’s just ignore those warnings. Or… as it turns out… these warnings are frequently causing 429 rate limit errors and our logs are full of

image

Would it be possible to well, rate limit those warnings on the client, so they don’t trigger all those requests? Or exempt POST /logs/ from rate limiting?

Tagging @outofthebox @WorldIsMine

6 Likes

Thanks @RGJ! I think this would improve performance.

2 Likes

I can confirm, happening on my site. Getting this if we open too many things too fast:

Even liking things too fast can now cause 429 errors. All because of two little depreciated icons.

2 Likes

I thought @pmusaraj dealt with this already? Not sure.

1 Like

The icon deprecation warnings are rate-limited thanks to FIX: Limit requests and include data when reporting deprecated icons · discourse/discourse@7737ecd · GitHub by @david.

You should replace the deprecated icons, that will remove the log entries and the post requests to /logs entirely. Plus, the old name fallbacks will be gone very soon (i.e. next few weeks).

6 Likes

Thanks @pmusaraj, I am going to further investigate what could be causing this.

4 Likes

Ok, I found something. This is not the problem @DaveK was having though.

They are indeed rate-limited, but Logster rate-limits them even further, at one per minute per IP, resulting in 429 errors when there are multiple deprecation warnings in a single page load.

This actually causes deprecation warnings to get lost, making the /logs less valuable as a tool to find all deprecations…

a 1 minute rate limit to all JS error reporting per IP

3 Likes