Normally, actions such as Liking are rate-limited, and when you hit the limit, you get a message telling you you’ve hit the limit. However, in 1.3.0beta9, it seems those popups are no longer appearing.
Edit: Possibly linked to this issue?
AI-generated summary
No rate-limit popups is an issue in Discourse 1.3.0beta9 where users do not receive a notification when they hit the rate limit for actions like liking. Instead, the action appears to fail, giving the impression of a software error Yuun.
The issue is possibly linked to a separate problem and may be related to an Ember 1.10 regression codinghorror. However, the popup library itself is working, as evidenced by its use in other situations like canceling a post Onyx.
@eviltrout identified and fixed an unrelated issue with the “oops, are you sure you want to post in a different topic” error, but has since fixed the rate limit notification issue as well: https://github.com/discourse/discourse/commit/94ca9ed11f95415f6644e4de50a77a9b7e934d31. The issue also affects administrative action rate limits, which predated beta 3 Onyx. A separate issue for admin rate limits has been requested sam.
14 „Gefällt mir“
I’m seeing this issue as well. When you hit the rate limit, any further likes look like the forum is attempting and failing to apply them - the text saying ‘you liked this’ comes into place before quickly being removed.
This makes it look (to the user) like the forum software is running into errors instead of said user hitting an intentional limit, which is a bit unfortunate.
I’m going to guess that the bootbox library got broken somehow?
Yeah maybe another Ember 1.10 regression for @eviltrout ?
You mean the popup box library, guessing by the name? Still shows up when you want to cancel a post, so it’s not all popups it seems.
1 „Gefällt mir“
The popup library is definitely working. I did identify and fixed the issue with the “oops are you sure you want to post in a different topic” regressing:
https://github.com/discourse/discourse/commit/8e395a94d4b321554762c46461c2b11038046cd4
I will have to look at the rate limit one though.
7 „Gefällt mir“
Also, it apparently happened to administrative action rate limits since before beta 3. Can’t find a report here at the moment, though, if there was one.
Can you open a separate one on the admin rate limits?
And I’ve fixed the issue with rate limits not showing up for ActionSummary issues (such as liking):
https://github.com/discourse/discourse/commit/94ca9ed11f95415f6644e4de50a77a9b7e934d31
Thanks for letting me know!
4 „Gefällt mir“