No rate-limit popups


#1

Normally, actions such as Liking are rate-limited, and when you hit the limit, you get a message telling you you’ve hit the limit. However, in 1.3.0beta9, it seems those popups are no longer appearing.

Edit: Possibly linked to this issue?


(Sam) #2

I’m seeing this issue as well. When you hit the rate limit, any further likes look like the forum is attempting and failing to apply them - the text saying ‘you liked this’ comes into place before quickly being removed.

This makes it look (to the user) like the forum software is running into errors instead of said user hitting an intentional limit, which is a bit unfortunate.


(Kane York) #3

I’m going to guess that the bootbox library got broken somehow?


(Jeff Atwood) #4

Yeah maybe another Ember 1.10 regression for @eviltrout ?


(Onyx) #5

You mean the popup box library, guessing by the name? Still shows up when you want to cancel a post, so it’s not all popups it seems.


(Robin Ward) #6

The popup library is definitely working. I did identify and fixed the issue with the “oops are you sure you want to post in a different topic” regressing:

I will have to look at the rate limit one though.


(Onyx) #7

Also, it apparently happened to administrative action rate limits since before beta 3. Can’t find a report here at the moment, though, if there was one.


(Sam Saffron) #8

Can you open a separate one on the admin rate limits?


(Robin Ward) #11

And I’ve fixed the issue with rate limits not showing up for ActionSummary issues (such as liking):

https://github.com/discourse/discourse/commit/94ca9ed11f95415f6644e4de50a77a9b7e934d31

Thanks for letting me know!


(Régis Hanol) #12