A bug was reported where the count on the /tags page in Discourse 1.7.0.beta7 was incorrect, showing a higher number than the actual topics associated with a tag. The issue was suspected to be related to deleted topics not being reflected in the tag count. Osama and clay were able to reproduce the issue by creating a topic with a tag, deleting the topic, and observing that the tag count remained unchanged. GSeven also suggested that private messages created from topics might contribute to the issue. However, jomaxro doubted this was the cause. After investigation, neil committed a fix, ensuring that deleted topics are no longer included in the tag count.
Summary: Over at Stonehearth it was noticed by an Admin today that the count on the /tags page is incorrect for some tags.
Steps to reproduce:
Unknown.
Expected Results:
Number next to tags matches number of topics seen when viewing individual tag page.
Actual Results:
Number next to tags is greater than the number of topics seen when viewing individual tag page.
Notes:
The difference between the number of topics with a tag and the number displayed appears to be constant i.e. ui had the number 5 but had 3 topics, adding the ui tag to another topics caused the number to increase to 6.
This is known to be an issue with the following tags (this list may be incomplete): ui, ai, crashes,
I checked adding ?status=deleted to the end to the URL, no deleted topics appeared. I’m a moderator so I would see unlisted topics, and the person who reported this to me is an Admin, so she would see if there were any topics in an admin category that I couldn’t see.
Same issue when logged out. Still seeing the number 6 but 4 topics for ui.
I don’t fully understand ‘make a topic into a private message’ yet, but i just made a topic, tagged it and turned it into a private message, and the tag count went up by one on the tag page.
could it be that?
deleting that private message keeps the tag count at +1
Certainly possible, but I highly, highly doubt it. We don’t use that function very much, and never for bug reports (the category where these tags are used).
I’m also seeing this problem with deleted topics, exactly as @Osama describes. We’re using tags heavily in the project in question and have need to sometimes automatically create a large number of tagged topics (importing data from elsewhere). The auto-imports occasionally catch unrelated content and we delete the topics, but the orphaned tags and incorrect tag counts persist.
I’m happy to give you access to the instance in question. Just PM me if so.
edit: not sure if it matters, but in step 2, “Later” means like a week later. I mention this in case there’s a sidkiq job that runs on a delayed schedule that affects tag processing. For the instance in question, I deleted the topics mentioned months ago and the orphaned tags and incorrect counts remain.
