Introducing fast edit

That is highly improbable. (Without looking at the code changes for this commit) the changes are just to the front/Ember end, and there are specs in place that test security issues like who can edit what.

I tried (on your forum) and couldn’t do it. I couldn’t see that post 1818 had been edited.

6 Likes

Can you point me where you have seen this report please? The post you linked is made by a moderator, making the behavior expected. If you can edit a post, you can fast edit it.

I can confirm what @pfaffman said, it’s an all client side feature, even if it there was a bug showing the fast edit button/form when you actually can’t, it would fail to save it.

If you have any reproduction/info on this, I’m certainly interested to see/fix it.

8 Likes

What version will have this feature for self hosted?

Currently running 2.8.0beta6

Thanks!

1 Like

Just upgrade and you’ll have it.

3 Likes

Today @pmusaraj added support for escape (cancel) and meta key+enter (save). Later I added support for triggering quote q and fast edit e. Fast edit is now even faster!

10 Likes

I’m finding this unreliable right now. Sometimes hitting e opens up the quick editor. Other times it opens up the full editor. This is even when I just highlight a single word with no special formatting, so I don’t think it’s falling back to the full editor by design.

I don’t know how consistently this will reproduce, but in the first paragraph of this post, “think” opens the full editor, “new” opens the quick editor, “spacing” opens the full editor, and “fine” opens the quick editor.

Also note that whatever I was doing got the draft for the post into a bad state. After a while, when I’d hit e a popup would appear telling me there was a draft open in another window (despite this being the only window) and I’d have to reload the page and delete the draft. This is despite me always just hitting ESC after the full editor appeared and never actually making any changes before closing it. At least in some cases, the very first time it opens the full editor instead of the quick editor, it saves a draft. I can immediately see it appear in the user menu where it adds the number of drafts in parentheses.


This also seems like a recent change, but I just noticed that after highlighting some text, the Quote button gets focused on. This means I can’t use Shift + Arrow to change what text is highlighted.

EDIT: Focusing on the Quote button (or something related) also messes things up on mobile (at least on iPhone). At first it doesn’t look like what you highlighted was actually highlighted. But this is just a minor UX issue. The bigger problem is that if you highlight something else without tapping the screen to unhighlight the first thing, the Quote button doesn’t move and hitting the Quote button quotes the first thing you highlighted, not what’s currently highlighted.

5 Likes

Thanks @seanblue, we’ve temporarily reverted the q and e shortcuts while we work on a fix. If you update your site to the latest tests-passed, things should be working reliably again (albeit without the new shortcuts)

9 Likes

We just merged a new implementation of the q and e shortcuts which should be much safer. That’s now live in tests-passed (and here on Meta).

12 Likes

Just a note that this is expected, fast edit makes few tradeoffs to work and if the selection (highly plausible if only selecting one word) is present multiple times in the text it will fallback to full composer.

15 Likes

I’ve got the same problem and the CSS selectors don’t seem to be granular enough to override in an easy way unless I’m missing something?

4 Likes