Landing Pages Plugin 🛩

Develcoder · February 14, 2022, 9:03am

Develcoder | Join I don’t understand why this part

MattiaB · June 16, 2022, 3:25pm

Hi @angus, I tried installing this plugin on my Discourse instance but I kept getting errors after trying to rebuild app. This should be the relevant part:

I, [2022-06-16T15:13:33.339825 #1]  INFO -- : > cd /var/www/discourse && su discourse -c 'bundle exec rake db:migrate'
rake aborted!
Gem::LoadError: can't activate jquery-rails-4.4.0, already activated jquery-rails-4.5.0
/var/www/discourse/lib/plugin_gem.rb:27:in `load'
/var/www/discourse/lib/plugin/instance.rb:773:in `gem'
/var/www/discourse/plugins/discourse-landing-pages/plugin.rb:20:in `activate!'
/var/www/discourse/lib/plugin/instance.rb:679:in `instance_eval'
/var/www/discourse/lib/plugin/instance.rb:679:in `activate!'
/var/www/discourse/lib/discourse.rb:279:in `block in activate_plugins!'
/var/www/discourse/lib/discourse.rb:276:in `each'
/var/www/discourse/lib/discourse.rb:276:in `activate_plugins!'
/var/www/discourse/config/application.rb:228:in `block in <class:Application>'
/var/www/discourse/lib/plugin.rb:6:in `initialization_guard'
/var/www/discourse/config/application.rb:227:in `<class:Application>'
/var/www/discourse/config/application.rb:81:in `<module:Discourse>'
/var/www/discourse/config/application.rb:80:in `<top (required)>'
/var/www/discourse/Rakefile:7:in `require'
/var/www/discourse/Rakefile:7:in `<top (required)>'
/var/www/discourse/vendor/bundle/ruby/2.7.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:25:in `load'
/usr/local/bin/bundle:25:in `<main>'
(See full trace by running task with --trace)
I, [2022-06-16T15:13:34.530066 #1]  INFO -- : gem install jquery-rails -v 4.4.0 -i /var/www/discourse/plugins/discourse-landing-pages/gems/2.7.6 --no-document --ignore-dependencies --no-user-install
Successfully installed jquery-rails-4.4.0
1 gem installed

I, [2022-06-16T15:13:34.530330 #1]  INFO -- : Terminating async processes
I, [2022-06-16T15:13:34.530366 #1]  INFO -- : Sending INT to HOME=/var/lib/postgresql USER=postgres exec chpst -u postgres:postgres:ssl-cert -U postgres:postgres:ssl-cert /usr/lib/postgresql/13/bin/postmaster -D /etc/postgresql/13/main pid: 42
103:signal-handler (1655392414) Received SIGTERM scheduling shutdown...
I, [2022-06-16T15:13:34.530403 #1]  INFO -- : Sending TERM to exec chpst -u redis -U redis /usr/bin/redis-server /etc/redis/redis.conf pid: 103
2022-06-16 15:13:34.530 UTC [42] LOG:  received fast shutdown request
103:M 16 Jun 2022 15:13:34.546 # User requested shutdown...
103:M 16 Jun 2022 15:13:34.546 * Saving the final RDB snapshot before exiting.
2022-06-16 15:13:34.551 UTC [42] LOG:  aborting any active transactions
2022-06-16 15:13:34.553 UTC [42] LOG:  background worker "logical replication launcher" (PID 51) exited with exit code 1
2022-06-16 15:13:34.554 UTC [46] LOG:  shutting down
103:M 16 Jun 2022 15:13:34.668 * DB saved on disk
103:M 16 Jun 2022 15:13:34.668 # Redis is now ready to exit, bye bye...
2022-06-16 15:13:34.724 UTC [42] LOG:  database system is shut down


FAILED
--------------------
Pups::ExecError: cd /var/www/discourse && su discourse -c 'bundle exec rake db:migrate' failed with return #<Process::Status: pid 1735 exit 1>
Location of failure: /usr/local/lib/ruby/gems/2.7.0/gems/pups-1.1.1/lib/pups/exec_command.rb:117:in `spawn'
exec failed with the params {"cd"=>"$home", "hook"=>"db_migrate", "cmd"=>["su discourse -c 'bundle exec rake db:migrate'"]}
bootstrap failed with exit code 1
** FAILED TO BOOTSTRAP ** please scroll up and look for earlier error messages, there may be more than one.
./discourse-doctor may help diagnose the problem.
bd8d903e1ec861801fdd32f7c35089aaebb97ca210dbe6eb5d584fc58379773e

I think this is the problem: Gem::LoadError: can't activate jquery-rails-4.4.0, already activated jquery-rails-4.5.0
Should be an easy fix, right? Just need to update dependencies from gem "jquery-rails", "4.4.0" in plugin.rb to gem "jquery-rails", "4.5.0"?

Thank you for this plugin.

nathank · June 21, 2022, 8:48am

The plugin does seem to be down. You might need to wait until the first week of July for a patch though.

https://discourse.pluginmanager.org/t/discourse-landing-pages-master-does-not-work-on-tests-passed/145

angus · July 28, 2022, 8:46pm

This plugin is working with the latest version of Discourse again

Kuro22 · July 29, 2022, 3:27am

Happy to learn about your recovery from covid. Thank you for fixing the plugin in this condition… Get more rest!

angus · July 29, 2022, 1:51pm

Unfortunately, this plugin is being retired, which is why it has an #end-of-life tag. I won’t go into the technical weeds here, but it no longer makes sense to keep maintaining it in light of some changes in discourse/discourse and the overall workload and resource allocation within Pavilion.

The plugin works with the latest tests-passed, however it will no longer be updated along with any changes made to discourse/discourse. If someone wishes to take this up as a project in the future, I’d be happy to work with them on it.

sunjam · July 29, 2022, 4:16pm

Thanks for working on it; it has been a lot of fun to use.

Would anyone be able to point towards the changes in discourse/discourse we can look to instead for the future?

angus · July 29, 2022, 4:20pm

I’m glad!

Ah sorry, I didn’t mean that there will be an alternative in discourse/discourse (although Page Publishing may suit some use cases). I meant that the technical structure of Discourse has changed in such a way to make this plugin unfeasible without a significant amount of work to change how it works structurally. We’re quite busy with other work in Pavilion at the moment, and I can’t in good conscience promise to maintain this plugin through any further changes in Discourse.

Pavilion is working on our own new landing pages. We’ll be using Hugo instead of this plugin.

sunjam · July 29, 2022, 4:24pm

Cool, you might like this in-progress “landing page” that has been whipped together from a category and tag group. It is working pretty well. Nothing fancy, but works.

angus · July 29, 2022, 4:27pm

Nice! It’s using this plugin?

sunjam · July 29, 2022, 4:30pm

No, created with Vue and uses Discourse API.

darkpixlz · January 8, 2023, 1:14am

Hello, trying to use this but when importing a ZIP I get an error.

Doing this because i need the .css file and .js.

merefield · January 8, 2023, 8:12am

See: Landing Pages Plugin 🛩 - #47 and the tag end-of-life

ValGun · July 10, 2023, 4:32pm

@angus is it possible to use bootstrap for creation of main page (login) page of Discourse instance?
Thank You

JammyDodger · September 4, 2023, 11:59am

I think we’ve had a report of this plugin hiding the sidebar’s Edit Custom Section modal:

I’ll move the tag over to broken.

angus · September 19, 2023, 10:52pm

I’m happy to say that @cabidop has breathed new life into this plugin. It is no longer broken . See further

github.com/paviliondev/discourse-landing-pages

Fixed deprecation warnings and bugs on page operations

paviliondev:main ← cabidop:main

opened 12:28PM - 08 Sep 23 UTC

cabidop

+3361 -202

Hi, @angusmcleod! Not sure if you are paying any attention at all to the plugin,… but I recently started working with Discourse and found that Landing Pages filled exactly the gap I just needed for a project. Seeing that it was unmaintained I started my own simplified version of your plugin, but this week I decided to give it a go and update yours so here we are now 😄 . Although I am already using my fork, I would appreciate if you could take a look to this PR to include the changes in the main repository so everyone can benefit from them. The list is not huge as I mainly focused on removing deprecation warnings and bringing the basic functionality back to life: - Cleaned Ruby and Javascript deprecated code when loading the plugin. - Fixed the "export page" functionality which solves #4, as some Javascript bits were missing for it to properly trigger. - Fixed the "import page" feature too. This required a little bit more effort as the modal [needed to be migrated](https://meta.discourse.org/t/converting-modals-from-legacy-controllers-to-new-dmodal-component-api/268057) and there were some mismatches in the Ruby code between the exported and the imported information. - Small fix to the "delete page" feature to remove the recently deleted page from the list. There are still some small issues with the save functionality (e.g. you can never remove categories and group once you added them) and I have not reviewed yet the global and remote functionality, but at least the plugin is now on a non-broken state. If you think it is too much to review in one go let me know as I can definitely make multiple PRs, each commit is more or less self-contained. Thanks a lot in advance and hope that you are still around for this!

cabidop · September 20, 2023, 12:02am

Thanks for the mention, @angus ! Happy to help with the plugin, I will be around here (and also on Github) so feel free to reach out.

lejeczek · October 24, 2023, 5:08pm

Hi.
Does the plug-in remain functional, with Blog landing pages as of today?
I’m new to the whole thing & when I try it, it installs & when I follow the docs (ones I found) I get an error about “body” (which I found no mention for) which I leave as is, empty.
Perhaps I missing something obvious & trivial.

cabidop · October 25, 2023, 5:27am

Hi, @lejeczek! I wasn’t testing the Landing Pages Blog repository so I don’t know if it’ll still be fully compatible, but there’s definitely a bug in this plugin that prevents the blog pages to load.

I’ve just pushed a small fix for it, once it’s ready to use I’ll let you know.

angus · October 25, 2023, 8:29am

The fix has been merged