Link behavior inconsistent

Contribute Bug

AI-generated summary

Link Behavior Inconsistent

A bug has been reported where clicking on links with query strings in the header, specifically those generated by the Assign plugin and Custom Header Links theme component, results in inconsistent behavior.

When clicking between links with query strings, or clicking the same link twice, the URL flips from the expected query string (e.g. /latest?assigned=me or /latest?assigned=*) to /latest, returning the wrong posts.

joffreyjaffeux has investigated and concluded that the issue is likely with Discourse itself, not the Custom Header Links theme component. Two commits were made to resolve the issue, but a subsequent commit (bfda9d3b50bd8e027024b62aa0b7e68611248073) reintroduced the bug. Reloading the page is a possible workaround.

1

Haven’t been able to pin down whether this is due to a plugin (Assign) or theme component (Custom Header Links) but as they’re both official I decided to split it down the middle and just file this is a Contribute > Bug

New instance, only has those components installed. Header Links is necessary because Assign doesn’t appear to add Top Menu options for ‘Assigned to me’ ‘Assigned to All’, that kind of thing.

The first time either of those links are clicked, they show the correct assigned posts. If one is clicked after the other, or the same link gets clicked twice, then it flips from /latest?assigned=me or /latest?assigned=* to /latest which means the wrong posts are returned.

So, from / I click “My Tasks” and get /latest?assigned=me and then I click “All Tasks” and instead of being directed to /latest?assigned=* I’m directed to /latest. Also, if I’m already on either page and click the link again I’m directed to /latest.

v2.3.0.beta5 +200

2

Can you give your custom header links settings please ?

3

Sure, they’re:

My Tasks,My Tasks,/latest?assigned=me,vdm,self

and

All Tasks,All Tasks,/latest?assigned=*,vdm,self
1 Like
4

Ok looked at it a little bit, I can say for sure it’s not related “Custom Header links” theme component.

You could for example reproduce multiple times when clicking on the assigned tag under a topic:

36
36302×124 3.43 KB

The issue is probably in Discourse itself, I feel like discourse-assign is generating the correct URL, will dig more later.

1 Like
5

I ended up doing two commits:

https://github.com/discourse/discourse-custom-header-links/commit/bfda9d3b50bd8e027024b62aa0b7e68611248073

https://github.com/discourse/discourse-assign/commit/046f1db466d3f6e01a41217c8593001dc66b21ce

This will now make a full reload but will avoid losing query params

6 Likes
8

This commit:

https://github.com/discourse/discourse-custom-header-links/commit/175a027582eac0b95803b3675ea37faf527ae68c

Reintroduces this bug:

It’s not just clicking the same link where the issue presents. Clicking between links with querystrings is fundamentally broken by this change too.

If I click the link for ‘Assigned to Me’ latest?assigned=me and follow it with a click to ‘All Tasks’ latest?assigned=* it instead takes me to /latest.

The alternative, reloading the page, seems like a small inconvenience in comparison.

2 Likes