Missing Custom Header Links after update

AI-generated summary

After an update, users reported missing custom header links in Discourse. leopedrini noticed the issue and shared screenshots showing the missing links. Arkshine explained that a recent change introduced a locale attribute, causing links without a specified locale to not display if the user’s language differs. The workaround is to add ,en to the links in settings, which leopedrini confirmed resolved the issue. Arkshine acknowledged this as a bug and submitted a fix via a pull request, which was approved and merged by jordan.vidrine.

Hello.

I am using this

https://meta.discourse.org/t/custom-header-links/90588/155

But after update (10 minutes ago) the links are missing (not showing)

They added a locale attribute to the links. This means a link with an “en” tag won’t appear if the current user’s language is “fr”, for example.

Though, if you don’t provide a locale, it should show them by default. There is a bug here.

An immediate fix would be to add ,en to your links in the settings.

2 Likes

Thanks, after adding (workaround) it is working fine again:

Links are back:

Note: I don’t know if I should flag this as a Solution (?) or leave it “Unsolved”, as problem will show to those who not apply this workaround.

Also, i know i should have read all documentation of the component, and added “, en”… :frowning:

1 Like

It’s still a bug. I’ve made a PR to fix it:
https://github.com/discourse/discourse-custom-header-links/pull/31

10 Likes

Approved & merged :+1:

7 Likes