Missing text on the Data Explorer UI

Bug
1

In this screenshot, you can see that the table headers for “Query”, “Created By” and “Last Run At” are missing:

image
image1149×297 18.9 KB

If you look at the code, anything defined with labelKey in .hbs is not showing up:

https://github.com/discourse/discourse-data-explorer/blob/df9e21911e6ee3145d56b25f377218f59df0e471/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs#L178

but text defined with {{i18n}} is showing up fine:

https://github.com/discourse/discourse-data-explorer/blob/df9e21911e6ee3145d56b25f377218f59df0e471/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs#L183

I tried replacing instances of labelKey with label and that didn’t fix it. @gerhard, is this a known issue or could it be related to this recent change?

https://github.com/discourse/discourse-data-explorer/commit/ab1ec9cb6996505ba787976805940bc4a591e5bf

3 Likes
2

No, this must be a different issue. Maybe due to changes to https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/app/components/directory-toggle.js?

5 Likes
3

Issue fixed by replacing directory-toggle with table-header-toggle - PR:

https://github.com/discourse/discourse-data-explorer/pull/58

6 Likes