{more_replies} sometimes returns no value

(Erik Molenaar) #1

Hi there,

I notice the variable {more_replies} sometimes does not return a value.
On most posts it works, but for some, it just returns a blank: 07.31.2017-14.21.31

Check out live URL: Introduction to Ethernet | NetworkLessons.com

Please note I changed the template via filter discourse_replies_html, but this is still the case on the default Discourse templates (by removing the filter). I did not see any errors in my PHP logs.

(Simon Cossar) #2

If there are no more replies, then it just returns an empty string. For this post Introduction to Ethernet | NetworkLessons.com what I’m seeing is 3 replies on the forum and 3 replies displayed on WordPress, so more_replies is returning an empty string. Are there cases on your site where there are more replies on the forum than are displayed on WordPress and the more_replies text is empty?

I see that I should add a filter to the more_replies text. I can do that right away.

(Erik Molenaar) #3

Hi Simon,

I get it now, thanks. Since there are no more hidden replies, the string returns an empty string. Clear!

But still, there is a hyperlink with no link text, shouldn’t this be fixed?

Looking forward to your reply. Thanks!

(Simon Cossar) #4

I think in the default template it renders a p tag with no content when there are no replies. It doesn’t need to do that. I’ll fix it