Moving posts to new PM did not invite all participants

bug
1

Hi all,

let me just preface the new interface for moving posts around is great. :sunny:

But, I got recently burnt when moving posts from a topic to a new PM. I moved around 6 post from 3 different people (one of them me), but only two of them got invited to the PM. What tricked me was that the third person’s avatar was actually listed as a poster in the footer below the OP…
image

but I did not notice that she was not in the list of PM participants just bellow

image

Can anyone reproduce this problem? Or did I hit some weird edge case?

Thanks!

1 Like
13

I can confirm this. Today I changed a public topic with about 5 users and 9 posts. Only 2 of the users, as well as myself were invited.

1 Like
14

Can you repro this @rishabh?

15

I could not repro this on my dev install with a topic that had mods, admins and regular users.
I’ll now test on this topic itself, sorry about the notification(s).

Screenshot%20from%202019-02-09%2017-53-39
Screenshot from 2019-02-09 17-53-39.png733×158 20.9 KB

No repro on this Meta topic too :arrow_down:

Screenshot%20from%202019-02-09%2018-13-21

@JagWaugh @danekhollas Can you think of anything that’s possibly unusual about these users or topics that might hit an edge case?

5 Likes
16

Okay, I just reproduced this on a topic on try.discourse.org:

There were 10 participants in the topic but only two of them (the originator + the person performing the conversion) were in the list of participants after converting to a PM.

Screenshot%20from%202019-02-09%2018-28-34

3 Likes
17

No. The topic wasn’t particularly old, or long, and it didn’t have all that many users.

Here’s the summary:

image
image.png716×185 23.1 KB

Only the originator of the topic and myself were included in the PM.

I can’t remember now if I selected all the posts separately, or did it at the topic level - in any case all of the posts were in the PM.

18

Not really :frowning: In my case all three users were mods. And I was moving from a post in a private category (restricted to certain group).

19

Try data and users are so old, not entirely sure that is a valid repro unless the original topic was also from 2014 or older?

1 Like
20

Definitely not, topic was from this month. Our our original install is fairly old, 2014/2015, but the user in question was created in 2017. We are currently at 2.2.0-beta+100, but I did not notice any commits related to this feature since then.

Thanks for investigating!

21

Can you try varying the selection method @rishabh to see if that makes any difference?

2 Likes
22

In my case I only selected certain posts, not sure whether individually, maybe I clicked Select+below.

1 Like
23

I now have a consistent repro on this topic which happens ONLY if you follow these steps:

  1. From the topic wrench, click Select Posts…

  2. click select+below on the first reply (because the first post cannot be selected to move with this UI, that is only possible when doing a topic level move)

  3. move to new message

The posts were moved correctly but @danekhollas wasn’t invited to the PM even though he has four posts in this topic. Note that he is the OP and we couldn’t select the first post, maybe that’s the edge case.

Screenshot%20from%202019-02-11%2011-21-27

6 Likes
25

Fixed in

https://github.com/discourse/discourse/commit/dcd7b925327ac3523ccbf94216e43f3f6b56df52

6 Likes
26

This may need to be backported to stable?

1 Like
27

Agreed, backported to stable branch.

7 Likes