OP getting removed from PM when topic converted to PM?

Bug
1

I have a user who is saying that when they convert a topic to a PM, the original poster/topic owner is getting removed from the PM.

The process is to convert the topic to PM and then add the @support group. When that happens, the person who converted the PM (who is a member of the support group) gets removed from the PM (since that would duplicate his notifications), but the owner is also getting removed, so they then wonder why their post has been deleted.

It seems like adding the group to the PM is removing the topic owner.

I donā€™t see anything in the logs that suggests how this is happening.

3 Likes
2
Defunct test

Iā€™ve just had a run through and encountered a similar/the same issue:

  • Create topic
  • Topic wrench ā†’ make private message
  • Invite a group

  • A member (though not the OP) gets removed by the system.

system removes PM participant
system removes PM participant1080Ɨ1643 121 KB

However, replying to the topic still sends the removed user a high priority notification, which seems to suggest theyā€™re not ā€˜removedā€™ removed.

Edit: I mucked up the Test_Users in the Group, and borked the test. My apologies. I will try a clean one.

Fresh test (This time making sure my group user was not part of the original topic :slightly_smiling_face:)

This time I used a TL1 test user as my OP, rather than admin.

  • Create public topic as TL1 user
  • Convert topic to PM (as admin)
  • Invite Group (as admin)

  • OP gets removed, and no record is left. User does not receive notifications about replies

Topic to PM test1a
Topic to PM test1a1080Ɨ1535 136 KB

Topic to PM test 1b
Topic to PM test 1b1080Ɨ1075 76.1 KB

Iā€™m wondering if itā€™s because that test user doesnā€™t have permission to speak to that group? Iā€™ll have another pop. :slightly_smiling_face:

Iā€™ve lost myself in this a bit, so may have to go and have a lie down, but it seems to lose the OP at the point of topic->PM conversion:

Topic to PM test2a
Topic to PM test2a1080Ɨ1411 92.6 KB

Topic to PM test2b
Topic to PM test2b1080Ɨ882 53.4 KB

The OP has no record for that topic in topic_allowed_users

3 Likes
3

That seems to be what is being reported.

It seems that this is a new behaviour. I donā€™t know if itā€™s intentional, but it seems like a bug that you would remove the topic originator from a message when you change it to a PM?

1 Like
4

I thought it seemed unusual. I couldnā€™t think of a circumstance where youā€™d convert and want to lose the OP as a participant?

2 Likes
5

The only recent commit I can find that I think might relate is FIX: Update user stat counts when post/topic visibility changes. (#15ā€¦ Ā· discourse/discourse@b876ff6 Ā· GitHub but it doesnā€™t look like it should be connected. Perhaps something else is changing topic_allowed_users in some way that I donā€™t understand.

6

Iā€™m seeing the same behaviour on other sites too. Seems a bit odd to ā€˜kickā€™ the OP out when the public topic is moved to a private one. Not a fan of talking to myself, but thatā€™s how it ends up :slight_smile:

7

Thanks, Matthew. Do you think that this is a regression of some kind? Do you believe that this ā€œremove the OP from the topic when itā€™s made privateā€ is a feature, or a bug?

8

My guess would be a bug.

I canā€™t see why you would convert a public thread to a PM, and then talk to yourself? Or maybe Iā€™m just not mad enough for that :sweat_smile:

1 Like
9

This is still proving to be an issue for us.

Is this a bug, or is this intended? Can anyone confirm, please?

1 Like
12

I believe this was fixed in the Latest release. If you upgrade it should all be sorted. :+1:

(and Iā€™ve just tested it on my test site, and it works for me)

4 Likes
13

Thanks, @JammyDodger! I hadn 't noticed that commit. @Parker1090 , your site is updating now.

3 Likes