Notification levels (Watching, etc.) - All titles incorrect for Private Messages (Part 2)

Continuing the discussion from Notification levels (Watching, etc.) - All descriptions incorrect for Private Messages:

@osama you again for the fix. Having just gone back and looked at this, it turns out that it’s not just the mapping for the descriptions which are incorrect for PM type, it’s also the mappings for the notification titles (Watching etc.)

The four different editable notification titles for private messages in Discourse have the following names
1.js.topic.notifications.watching_pm.title
2.js.topic.notifications.tracking_pm.title
3.js.topic.notifications.regular_pm.title
4.js.topic.notifications.muted_pm.title

However the private message /t/ page is picking up the “normal” (category) topic titles which are:
1.js.topic.notifications.watching.title
2.js.topic.notifications.tracking.title
3.js.topic.notifications.regular.title
4.js.topic.notifications.muted.title

Would you be able to implement a similar fix?

BTW I have checked and there seem to be no other problematic mappings around these message notifications.

7 Likes

Fixed in

https://github.com/discourse/discourse/pull/6038

Thanks for the reports @jerry0 :trophy:

6 Likes

This topic was automatically closed after 31 hours. New replies are no longer allowed.