Poor CSS / HTML element naming on user profile page

If a profile background image is set, it is incorrectly shown above the profile details on user profile page. This behavior was introduced in
https://github.com/discourse/discourse/commit/814aee343be3e3d36199ba0a6bc1c13f34121687#diff-627a1051c75254f2996005eaa90bd13d
where the background image was moved to its own div. I think this was an unexpected side effect, but if it is intentional, you might want to rename it a profile header image or something in the user profile settings.

2 Likes

Can you provide a screenshot of this problem please?

Here you go:

@awesomerobot did you want to confirm this?

Sure we can rename it to header instead of background. The overlay effect we used previously made profiles slightly harder to read and the overlay was dark to the point where most of the image was obstructed anyway (if you’re wondering why the change happened).

7 Likes

Renamed to header here (commit message has it backwards :man_facepalming:)

7 Likes