/posts create and update consistency

angus · April 21, 2025, 9:07am

The WP Discourse plugin currently uses a single request to create posts when publishing posts to Discourse and (potentially) two requests when updating posts.

The first request on update is to PostController#update, for the main post attributes, and the second is to TopicController#update to update the topic’s featured link, if that feature is being used.

There is some attempt in PostController#update to maintain consistency with PostController#create, e.g.

github.com/discourse/discourse

app/controllers/posts_controller.rb

main


      
          changes = { raw: params[:post][:raw], edit_reason: params[:post][:edit_reason] }
          
          Post.plugin_permitted_update_params.keys.each { |param| changes[param] = params[:post][param] }
          
          # keep `raw_old` for backwards compatibility
          original_text = params[:post][:original_text] || params[:post][:raw_old]
          if original_text.present? && original_text != post.raw
            return render_json_error(I18n.t("edit_conflict"), status: 409)
          end
          
          # to stay consistent with the create api, we allow for title & category changes here
          if post.is_first_post?
            changes[:title] = params[:title] if params[:title]
            changes[:category_id] = params[:post][:category_id] if params[:post][:category_id]
          
            if changes[:category_id] && changes[:category_id].to_i != post.topic.category_id.to_i
              category = Category.find_by(id: changes[:category_id])
              if category || (changes[:category_id].to_i == 0)
                guardian.ensure_can_move_topic_to_category!(category)
              else
                return render_json_error(I18n.t("category.errors.not_found"))

However, a topic’s featured link is not currently part of that consistency.

I’d like to make a PR to discourse/discourse to allow topic featured_link updates via PostController#update. It would simplify the WP Discourse plugin’s update logic. I wanted to canvas the change here first in case I’m missing anything.

Topic		Replies	Views
WP Discourse "Update Discourse topic" error WordPress	25	3308	July 7, 2019
Editing linked Discourse posts/topics without changes being overridden by Wordpress? WordPress	14	1798	October 16, 2017
Existing topics on Discourse for new articles - expectations vs reality check if you don't mind WordPress	4	1043	July 3, 2018
Automatically Select Topic Category Based on Post Category? WordPress	8	915	October 10, 2022
WP Discourse plugin tips and tricks Administrators wordpress , reference	1	11898	May 15, 2018

/posts create and update consistency

Related topics